Pass unknown also as a second argument to the command:* event

[negiDharmendra]

We are trying to use this awesome library to handle command line arguments and flags in Taiko.

Example:

taiko [option] --> this opens an interactive repl.
taiko <js file> [option]  --> executes the js script.

There seems to be an issue related to unknown flags. When we provide the js file argument and pass an unknown flag commander does not complain about that. But when we pass only unknown flag without arguments commander prints a nice message that provides flag was invalid.

It would be great if the commander complains about the unknown flags even if they are passed after arguments.

[negiDharmendra]

In order to fix the issue, we need to pass the unknown parameter to the while emitting the 'command:*' event on the following file.

commander.js/index.js

Line 656 in 68545af

this.emit('command:*', args);

[shadowspawn]

Have you got a small example program?

(I do see the warning for unknown flags in my program which has subcommands, but looks like you have just an optional argument and options and no subcommands?)

[clarsen]

Attached is a PR that does the suggested behavior and adjustment of tests. I'm a little hesitant about it though because it breaks the existing default behavior of ignoring unknown options, instead resulting in an error.

While this is the desired behavior for my programs, others might be relying on the silent default handling of unknown options.

[shadowspawn]

I have reproduced this, and realised it is a duplicate of #561. Closing in favour of that open issue.

Thank you for your contributions.

[shadowspawn]

After deeper analysis I discovered that there are different behaviours depending on whether there is an action handler attached to the program. #965 is targeting the case when there is an action handler, and original report in #561 covering no action handler. Not sure which case applies to taiko but have an open PR and an open issue to cover the two possibilities, so will still leave this closed.