Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment inspector port for spawned subcommands #991

Merged
merged 9 commits into from
Jul 22, 2019

Conversation

shadowspawn
Copy link
Collaborator

Look for node inspector arguments used for configuring debugging and increment the port number. This avoids launch errors when debugging git-style subcommands from top-level command.

A call like this which implicitly uses default port of 9229

node --inspect pm.js sub

will spawn a sub-command with port number incremented:

node --inspect=127.0.0.1:9230 pm-sub.js

See earlier pull request with research and comments about approach of incrementing ports: #874

Related issues: #533 #838

Code can be reviewed by interested readers.
I have not minimised number of regex calls, could preflight with a simple search?
Opening as draft pull request because no changes yet to README or tests.

@shadowspawn
Copy link
Collaborator Author

I have added tests, and check for --inspect before trying regex.

(I will update README after decide #990 as I moved --harmony in that PR.)

@shadowspawn shadowspawn marked this pull request as ready for review July 8, 2019 11:02
@shadowspawn
Copy link
Collaborator Author

Added section to README. All done. Ready for review.

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadowspawn shadowspawn merged commit 6d68637 into tj:release/3.0.0 Jul 22, 2019
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Jul 22, 2019
@shadowspawn
Copy link
Collaborator Author

Available now as a prerelease. See #1001

@shadowspawn shadowspawn deleted the feature/533-ports branch July 27, 2019 07:40
@shadowspawn
Copy link
Collaborator Author

@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants