Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak with Nunjucks template #291

Open
dail opened this issue Aug 11, 2017 · 2 comments
Open

memory leak with Nunjucks template #291

dail opened this issue Aug 11, 2017 · 2 comments

Comments

@dail
Copy link

dail commented Aug 11, 2017

When i do stress testing, I have found an memory leak issue with Nunjucks's renderString method, which is called in this library. I have opened an issue in Nunjucks procect.

With the renderString method, we can't use relative path in template. When I replace it with render method of Nunjucks, no memory leak, relative path can also works correctly. I suggest use render method instead of renderString in this library.

@edevil
Copy link

edevil commented Sep 27, 2018

Is this still a problem?

@titanism
Copy link

titanism commented Jun 8, 2023

We have forked this repository for maintenance and released it under @ladjs/consolidate, see https://github.com/ladjs/consolidate.js. We have merged PR's and updated it for email-templates. Please click the "Watch" button to get notified of all releases at https://github.com/ladjs/consolidate.js. Thank you 🙏

Screen Shot 2023-06-08 at 3 05 12 PM

PR welcome at the new repo once new release is published today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants