Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add squirrelly support #299

Open
nebrelbug opened this issue Nov 3, 2017 · 8 comments
Open

Add squirrelly support #299

nebrelbug opened this issue Nov 3, 2017 · 8 comments

Comments

@nebrelbug
Copy link
Contributor

Squirrelly is a high performance ExpressJS Template engine:
https://nebrelbug.github.io/squirrelly/
https://www.npmjs.com/package/squirrelly

@doowb
Copy link
Collaborator

doowb commented Nov 3, 2017

Please submit a PR with code, tests, and add the links to the README.md.

@nebrelbug
Copy link
Contributor Author

Will do

@nebrelbug
Copy link
Contributor Author

My forked repo contains code and links, and squirrelly works (I tested it) but I'm not sure how to do tests.

@doowb
Copy link
Collaborator

doowb commented Nov 8, 2017

Basically, just add a folder to the test/fixtures folder for squirrelly with a template. Then add a line to the main test file that looks like the lines for the other engines.

If squirrelly supports helpers, filters, and/or partials like some of the other engines, then you can follow the pattern of the other engines to add templates and tests for those features.

Then do a PR from your branch and I'll take a look and let you know if there's anything that should be changed.

@nebrelbug
Copy link
Contributor Author

Great! I'll do that.

@nebrelbug
Copy link
Contributor Author

@doowb sorry for the long delay! I've been completely rewriting Squirrelly.

I just made a pull request #317 which adds Squirrelly, and all tests (except for Hamlet) pass, including partials and helpers.

Would you mind reviewing the pull request?

Thanks so much!

@titanism
Copy link

titanism commented Jun 8, 2023

Will be merging your PR!

We have forked this repository for maintenance and released it under @ladjs/consolidate, see https://github.com/ladjs/consolidate.js. We have merged PR's and updated it for email-templates. Please click the "Watch" button to get notified of all releases at https://github.com/ladjs/consolidate.js. Thank you 🙏

Screen Shot 2023-06-08 at 3 05 12 PM

PR welcome at the new repo once new release is published today!

@titanism
Copy link

titanism commented Jun 9, 2023

Hi there - we unfortunately had to drop squirrelly support due to some issues in latest release of consolidate v1.0.0.

We commented out the code because we're not too familiar, but you might want to look at this stuff here and submit a working PR:

https://github.com/ladjs/consolidate/blob/2bf0a2012e3f8af20e806593b66327c7c28216da/lib/consolidate.js#L1898-L1928

https://github.com/ladjs/consolidate/blob/2bf0a2012e3f8af20e806593b66327c7c28216da/test/consolidate.js#L72-L74

https://github.com/ladjs/consolidate/blob/2bf0a2012e3f8af20e806593b66327c7c28216da/test/shared/helpers.js#L40-L61

(we basically tried to upgrade to v8 of squirrelly and could not find solutions to the errors from running npm test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants