Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exit with error if HEAD commit doesn't yet exist on remote #1155

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Exit with error if HEAD commit doesn't yet exist on remote #1155

wants to merge 1 commit into from

Conversation

mattcen
Copy link

@mattcen mattcen commented Aug 10, 2024

Fixes #1153

@mattcen mattcen mentioned this pull request Aug 10, 2024
Open
@hyperupcall
Copy link
Collaborator

LGTM! CI failure looks unrelated.

@spacewander
Copy link
Collaborator

The unit tests failed because we added an upstream check and they can't satisfy. Could we mock the upstream check in the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git-browse doesn't check if a commit exists on upstream
3 participants
@mattcen @hyperupcall @spacewander