-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS 11 has been announced; can_use_xz() should be updated #623
Comments
Um, yes, we didn't check the major version! Has not changed in soooooo long. |
By the way, nvs does something clever for version comparisons. For comparing (This amount of padding would be enough up until any of the version components requires more than three digits to write. I find it unlikely that macOS will ever release a version with one of the components being
|
I would prefer two separate checks for this. The unified version approach is handy if doing sorting or multiple checks, but for a single check, no need to be clever. |
I also just remembered that in macOS releases with xz support there is a shared/dynamic library Checking for the existence of this file should work for macOS, irrespective of OS version. So the options are down to:
|
A PR is up with the simple fix/staying close to the existing solution. #624 |
I can do a version of this at (It will take until there is a beta of macOS 11 to really confirm this is the right approach, but I'd be surprised if it isn't. And I think it's worth being ahead of the curve, so it "just works" for more users right on day one if macOS 11 usage. And to preempt any issue spam.) |
I agree, in that ideally I would try it on macOS 11 first, but I am happy shipping sooner as the change is consistent with the existing implementation and likely to Just Work. PR for |
FWIW there is a developer beta for macOS 11 "Big Sur", but I don't own a Mac, I only borrow them from time to time... And I'm not going to pay $100 to join the Apple Developer Program. https://www.digitaltrends.com/computing/how-to-download-macos-big-sur/ |
Shipped in Thanks @DeeDeeG |
Hi,
Apple has announced a macOS 11 release for some time in the future.
For inferring xz support, we currently look for the minor macOS version number (>= 9), but I reckon we should now also accept major version >= 11.
The text was updated successfully, but these errors were encountered: