-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
param=1¶m=2 is the same as param[]=1¶m[]=2 #38
Comments
there are no rules really, these are behaviours that other libraries support but I would agree |
@Somebi - Disagree. If you do a plain ole form post with multiple input fields off the same name, the browser will concat these values into a list, it won't just take the last value. |
I just accustomed to that behavior that param[]=value generates an array and param=value¶m=value takes the last one. I have created a small helper on client-side, which removes duplicated names. |
@Somebi - I'm curious, which other query string parsers act that way? I'm interested in making sure this query string parser behaves nicely. |
Well that was in php + apache. |
@Marak This is also the behavior in Ruby/Rails... in fact I was trying to replicate in Express the good old trick of preceding a checkbox input with a hidden field of the same name so that when the checkbox isn't checked I received "0" and when it is I get "1"... but I was surprised to realize that instead I get ["0", "1"] when it's checked. |
Just for information, the same question was asked here: http://stackoverflow.com/questions/1746507/authoritative-position-of-duplicate-http-get-query-keys And they linked to a great document that lists different ways that it is handled: https://www.owasp.org/images/b/ba/AppsecEU09_CarettoniDiPaola_v0.8.pdf. The most used is keep either the first or the last value, but there really are no consensus. Perhaps add an option for choosing which of the 4 different methods to use? The 4 being:
|
I Agree with fizker and Somebi. Please make it a useful convention to get rid of the extra controller code required so far. |
Looks like the same issue as: #9 Any forks with the "keep last" behavior? |
This shouldn't be this way, the last param should be taken instead of uniting them into an array.
The text was updated successfully, but these errors were encountered: