Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Assistant compatibility #36

Open
highground88 opened this issue Sep 10, 2021 · 7 comments
Open

Home Assistant compatibility #36

highground88 opened this issue Sep 10, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@highground88
Copy link

Any chance this can be modified to be a valid Home Assistant repository (Or HAC)?

e.g: https://github.com/ttvt/ModbusTCP2MQTT

@tjhowse
Copy link
Owner

tjhowse commented Sep 10, 2021

Sounds quite doable. I'm adding this link here for my own reference for the requirements for a repo to work via HACS: https://hacs.xyz/docs/publish/start

@tjhowse tjhowse added the enhancement New feature or request label Sep 10, 2021
@tjhowse
Copy link
Owner

tjhowse commented Oct 17, 2021

@highground88 Are you able to check whether this repo functions with HACS now? I've added the relevant metadata. I'd test it myself but I have a self-hosted HASS install that hasn't been updated in a while, so I don't think it plays nicely with HACS.

@tjhowse
Copy link
Owner

tjhowse commented Oct 17, 2021

Hm, it looks like the best fit would be an "add-on" for HASS, as opposed to an integration or plugin: https://developers.home-assistant.io/docs/add-ons/

@highground88
Copy link
Author

highground88 commented Oct 17, 2021

Hm, it looks like the best fit would be an "add-on" for HASS, as opposed to an integration or plugin: https://developers.home-assistant.io/docs/add-ons/

Happy to test - I'm currently using "https://github.com/TenySmart/ModbusTCP2MQTT" as an integration through Supervisor custom repo which seems to be working mostly ok. This is fine - but it would be better if everyone could install an add-on by searching for modbus / sungrow etc, without needing to search for and find the github repo manually.

@highground88
Copy link
Author

Sorry looks like some incompatibility still? Thanks for your efforts

HA custom
image

HACS custom
image

@tjhowse
Copy link
Owner

tjhowse commented Oct 17, 2021

That's awesome, thanks! I'll do a bit more digging into what's involved in making it compatible as an add-on.

@Sjeiz
Copy link

Sjeiz commented Jul 13, 2022

Any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants