Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Net452 - Replace with Net462 #210

Open
RFBomb opened this issue May 28, 2024 · 4 comments
Open

Deprecate Net452 - Replace with Net462 #210

RFBomb opened this issue May 28, 2024 · 4 comments

Comments

@RFBomb
Copy link
Contributor

RFBomb commented May 28, 2024

@PCAssistSoftware - You recently commented that your projects are using net4.8, which uses the Net452 dll (which i tested via a unit test and verified that is correct). Net452 has been out of support since 2022, and there are quite a few workarounds specific to net452 in the library, as it does not support NetStandard2.0 apis.

As such, I'm thinking that the project should drop support for net452, and replace with net462 per the lifecycle page. I can target net462 in the upcoming #209 as well, so that net452 gets one last bug-fixed release before dropping support entirely.

thoughts?

@PCAssistSoftware
Copy link
Collaborator

That is a really good idea and I completely agree

@PCAssistSoftware
Copy link
Collaborator

could perhaps jump straight to 4.7.2 rather than 4.6.2 as per your title? then be even more ahead of the curve / end of support etc

@RFBomb
Copy link
Contributor Author

RFBomb commented May 30, 2024

I thought about that, but my reasoning for 462 was that 462 was the recommended version from MS to upgrade to after the release of NetStandard2.0. Targeting 4.6.2 also covers 4.7, 4.7.1, and 4.7.2. And since 4.6.2 is 'supported until 2027', which the other 3 having no current end date, I figured it was easiest to target 462.

I did some benchmarks with 472, and found negligible differences in what I was benchmarking compared to 462, but net48 had some slight improvements (mostly still margin of error though in my opinion), which is why I target net462 and net48 in #209's PR, and not 472.

In any case, when the day comes in 2027, whoever is maintaining this by then can easily just change the target

@RFBomb RFBomb changed the title Deprecate Net452 - Replace with Net461 or Net472 Deprecate Net452 - Replace with Net462 May 30, 2024
@PCAssistSoftware
Copy link
Collaborator

That all makes perfect sense to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants