Skip to content

Commit 3d20a53

Browse files
committed
Merge branch '0.9-prerelease' of https://github.com/tkaitchuck/aHash into aarch64-regression
2 parents a15c358 + 0a0e493 commit 3d20a53

File tree

3 files changed

+65
-20
lines changed

3 files changed

+65
-20
lines changed

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ once_cell = { version = "1.18.0", default-features = false, features = ["alloc"]
8888

8989
[dev-dependencies]
9090
no-panic = "0.1.10"
91-
criterion = {version = "0.3.2", features = ["html_reports"] }
91+
criterion = {version = "0.5.1", features = ["html_reports"] }
9292
seahash = "4.0"
9393
fnv = "1.0.5"
9494
fxhash = "0.2.1"

src/aes_hash.rs

+32-9
Original file line numberDiff line numberDiff line change
@@ -261,13 +261,26 @@ impl Hasher for AHasherU64 {
261261
}
262262

263263
#[inline]
264-
fn write_u128(&mut self, _i: u128) {
265-
unreachable!("Specialized hasher was called with a different type of object")
264+
fn write_u128(&mut self, i: u128) {
265+
let i: [u64; 2] = i.convert();
266+
self.buffer = folded_multiply(i[0] ^ self.buffer, MULTIPLE);
267+
self.pad = folded_multiply(i[1] ^ self.pad, MULTIPLE);
266268
}
267269

268270
#[inline]
269-
fn write_usize(&mut self, _i: usize) {
270-
unreachable!("Specialized hasher was called with a different type of object")
271+
#[cfg(any(
272+
target_pointer_width = "64",
273+
target_pointer_width = "32",
274+
target_pointer_width = "16"
275+
))]
276+
fn write_usize(&mut self, i: usize) {
277+
self.write_u64(i as u64);
278+
}
279+
280+
#[inline]
281+
#[cfg(target_pointer_width = "128")]
282+
fn write_usize(&mut self, i: usize) {
283+
self.write_u128(i as u128);
271284
}
272285
}
273286

@@ -349,19 +362,29 @@ impl Hasher for AHasherStr {
349362
fn write_u8(&mut self, _i: u8) {}
350363

351364
#[inline]
352-
fn write_u16(&mut self, _i: u16) {}
365+
fn write_u16(&mut self, i: u16) {
366+
self.0.write_u16(i)
367+
}
353368

354369
#[inline]
355-
fn write_u32(&mut self, _i: u32) {}
370+
fn write_u32(&mut self, i: u32) {
371+
self.0.write_u32(i)
372+
}
356373

357374
#[inline]
358-
fn write_u64(&mut self, _i: u64) {}
375+
fn write_u64(&mut self, i: u64) {
376+
self.0.write_u64(i)
377+
}
359378

360379
#[inline]
361-
fn write_u128(&mut self, _i: u128) {}
380+
fn write_u128(&mut self, i: u128) {
381+
self.0.write_u128(i)
382+
}
362383

363384
#[inline]
364-
fn write_usize(&mut self, _i: usize) {}
385+
fn write_usize(&mut self, i: usize) {
386+
self.0.write_usize(i)
387+
}
365388
}
366389

367390
#[cfg(test)]

src/fallback_hash.rs

+32-10
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ impl Hasher for AHasherU64 {
212212
#[inline]
213213
fn finish(&self) -> u64 {
214214
folded_multiply(self.buffer, self.pad)
215-
//self.buffer
216215
}
217216

218217
#[inline]
@@ -241,13 +240,26 @@ impl Hasher for AHasherU64 {
241240
}
242241

243242
#[inline]
244-
fn write_u128(&mut self, _i: u128) {
245-
unreachable!("Specialized hasher was called with a different type of object")
243+
fn write_u128(&mut self, i: u128) {
244+
let i: [u64; 2] = i.convert();
245+
self.buffer = folded_multiply(i[0] ^ self.buffer, MULTIPLE);
246+
self.pad = folded_multiply(i[1] ^ self.pad, MULTIPLE);
246247
}
247248

248249
#[inline]
249-
fn write_usize(&mut self, _i: usize) {
250-
unreachable!("Specialized hasher was called with a different type of object")
250+
#[cfg(any(
251+
target_pointer_width = "64",
252+
target_pointer_width = "32",
253+
target_pointer_width = "16"
254+
))]
255+
fn write_usize(&mut self, i: usize) {
256+
self.write_u64(i as u64);
257+
}
258+
259+
#[inline]
260+
#[cfg(target_pointer_width = "128")]
261+
fn write_usize(&mut self, i: usize) {
262+
self.write_u128(i as u128);
251263
}
252264
}
253265

@@ -325,19 +337,29 @@ impl Hasher for AHasherStr {
325337
fn write_u8(&mut self, _i: u8) {}
326338

327339
#[inline]
328-
fn write_u16(&mut self, _i: u16) {}
340+
fn write_u16(&mut self, i: u16) {
341+
self.0.write_u16(i)
342+
}
329343

330344
#[inline]
331-
fn write_u32(&mut self, _i: u32) {}
345+
fn write_u32(&mut self, i: u32) {
346+
self.0.write_u32(i)
347+
}
332348

333349
#[inline]
334-
fn write_u64(&mut self, _i: u64) {}
350+
fn write_u64(&mut self, i: u64) {
351+
self.0.write_u64(i)
352+
}
335353

336354
#[inline]
337-
fn write_u128(&mut self, _i: u128) {}
355+
fn write_u128(&mut self, i: u128) {
356+
self.0.write_u128(i)
357+
}
338358

339359
#[inline]
340-
fn write_usize(&mut self, _i: usize) {}
360+
fn write_usize(&mut self, i: usize) {
361+
self.0.write_usize(i)
362+
}
341363
}
342364

343365
#[cfg(test)]

0 commit comments

Comments
 (0)