Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notebook): Support Launching Notebooks with CRD Directly #15

Merged
merged 5 commits into from
Apr 14, 2021

Conversation

Mirrored90
Copy link
Collaborator

No description provided.

Signed-off-by: Qingyu Wu <soupwu@tencent.com>
Signed-off-by: Qingyu Wu <soupwu@tencent.com>
@Mirrored90 Mirrored90 changed the title Support Support launch notebooks without gateways Apr 14, 2021
@Mirrored90 Mirrored90 changed the title Support launch notebooks without gateways feat(notebook): Support Launching Notebooks with CRD Directly Apr 14, 2021
Copy link
Collaborator

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test cases.

Thanks for your contribution! 🎉 👍

pkg/notebook/generate.go Outdated Show resolved Hide resolved
Signed-off-by: Qingyu Wu <soupwu@tencent.com>
pkg/notebook/reconcile.go Outdated Show resolved Hide resolved
pkg/notebook/reconcile.go Outdated Show resolved Hide resolved
Signed-off-by: Qingyu Wu <soupwu@tencent.com>
Signed-off-by: Qingyu Wu <soupwu@tencent.com>
@gaocegege gaocegege merged commit b54a22a into skai-x:master Apr 14, 2021
@Mirrored90 Mirrored90 deleted the notebook branch April 14, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants