Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix objects css props #197

Merged
merged 14 commits into from
Jul 29, 2017
Merged

Prefix objects css props #197

merged 14 commits into from
Jul 29, 2017

Conversation

tkh44
Copy link
Member

@tkh44 tkh44 commented Jul 28, 2017

What:

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Code complete

@codecov-io
Copy link

codecov-io commented Jul 28, 2017

Codecov Report

Merging #197 into master will decrease coverage by 1.36%.
The diff coverage is 81.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   90.91%   89.55%   -1.37%     
==========================================
  Files          22       22              
  Lines         859      900      +41     
  Branches      224      242      +18     
==========================================
+ Hits          781      806      +25     
- Misses         63       75      +12     
- Partials       15       19       +4
Impacted Files Coverage Δ
src/parser.js 96.42% <100%> (-3.58%) ⬇️
src/css-prop.js 100% <100%> (ø) ⬆️
src/babel.js 96.93% <50%> (-1.14%) ⬇️
src/ast-object.js 87.59% <81.33%> (-9.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f82bf0...51de199. Read the comment docs.

…h44/emotion into prefix-objects-revert

# Conflicts:
#	src/babel.js
#	src/parser.js
#	test/browserslist/__snapshots__/babel.test.js.snap
@tkh44 tkh44 requested a review from emmatown July 28, 2017 22:02
<h1
className="glamor-0"
className="css-nil"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this happening?

src/parser.js Outdated
@@ -6,9 +6,8 @@ import postcssJs from 'postcss-js'
import objParse from './obj-parse'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be postcss-js/parser

.glamor-0:-ms-input-placeholder {
background-color: green;
}

.glamor-0::placeholder {
background-color: green;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem.

@tkh44 tkh44 merged commit a50fe8b into master Jul 29, 2017
@tkh44 tkh44 deleted the prefix-objects-css-props branch July 29, 2017 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants