-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix objects css props #197
Conversation
support spread operator in object styles
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 90.91% 89.55% -1.37%
==========================================
Files 22 22
Lines 859 900 +41
Branches 224 242 +18
==========================================
+ Hits 781 806 +25
- Misses 63 75 +12
- Partials 15 19 +4
Continue to review full report at Codecov.
|
…h44/emotion into prefix-objects-revert # Conflicts: # src/babel.js # src/parser.js # test/browserslist/__snapshots__/babel.test.js.snap
<h1 | ||
className="glamor-0" | ||
className="css-nil" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this happening?
src/parser.js
Outdated
@@ -6,9 +6,8 @@ import postcssJs from 'postcss-js' | |||
import objParse from './obj-parse' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be postcss-js/parser
.glamor-0:-ms-input-placeholder { | ||
background-color: green; | ||
} | ||
|
||
.glamor-0::placeholder { | ||
background-color: green; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a problem.
…op-and-spread # Conflicts: # src/babel.js # src/obj-parse.js # src/parser.js # test/babel/__snapshots__/css-prop.test.js.snap # test/browserslist/babel.test.js
What:
Why:
How:
Checklist: