Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lerna #259

Merged
merged 19 commits into from
Aug 16, 2017
Merged

Lerna #259

merged 19 commits into from
Aug 16, 2017

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Aug 14, 2017

What:

Move everything into their own packages

  • emotion (core + aliases to the other packages for backwards compat until we do a major release)
  • babel-plugin-emotion
  • emotion-server
  • emotion-utils (internal utils/stuff that's used across packages)
  • react-emotion

emotion, emotion-utils and react-emotion have rollup builds with all their dependencies external so they're reused across the packages.
babel-plugin-emotion and emotion-server have babel builds

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Code complete

I wrote a codemod to change the imports but I'm not sure where we should put it. Should we link to it? put it in the emotion package? another package? a folder in the repo?

@codecov-io
Copy link

codecov-io commented Aug 14, 2017

Codecov Report

Merging #259 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   90.23%   90.28%   +0.05%     
==========================================
  Files          20       20              
  Lines         963      968       +5     
  Branches      260      261       +1     
==========================================
+ Hits          869      874       +5     
  Misses         76       76              
  Partials       18       18
Impacted Files Coverage Δ
...ages/emotion/test/extract/extract.test.emotion.css 100% <ø> (ø)
packages/react-emotion/src/index.js 100% <ø> (ø)
packages/emotion-server/src/index.js 100% <ø> (ø)
...ls/src/glamor/CSSPropertyOperations/CSSProperty.js 100% <ø> (ø)
packages/babel-plugin-emotion/src/index.js 97.74% <ø> (ø)
packages/babel-plugin-emotion/src/babel-utils.js 100% <ø> (ø)
packages/emotion-utils/src/hash.js 100% <ø> (ø)
packages/babel-plugin-emotion/src/parser.js 95% <ø> (ø)
packages/babel-plugin-emotion/src/macro-styled.js 100% <ø> (ø)
packages/babel-plugin-emotion/src/ast-object.js 89.36% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad8d7cf...5d8a6ad. Read the comment docs.

@emmatown emmatown requested a review from tkh44 August 14, 2017 09:56
@@ -0,0 +1,7 @@
require('babel-register')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be in the base directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants