-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lerna #259
Conversation
…ckage.json and add README.md to emotion package
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 90.23% 90.28% +0.05%
==========================================
Files 20 20
Lines 963 968 +5
Branches 260 261 +1
==========================================
+ Hits 869 874 +5
Misses 76 76
Partials 18 18
Continue to review full report at Codecov.
|
@@ -0,0 +1,7 @@ | |||
require('babel-register') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to be in the base directory?
What:
Move everything into their own packages
emotion, emotion-utils and react-emotion have rollup builds with all their dependencies external so they're reused across the packages.
babel-plugin-emotion and emotion-server have babel builds
Why:
How:
Checklist:
I wrote a codemod to change the imports but I'm not sure where we should put it. Should we link to it? put it in the emotion package? another package? a folder in the repo?