Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preact-emotion #273

Merged
merged 2 commits into from
Aug 20, 2017
Merged

Add preact-emotion #273

merged 2 commits into from
Aug 20, 2017

Conversation

emmatown
Copy link
Member

What:

Add a preact-emotion package with react aliased to preact

Why:

We only use createElement from react which preact exports but most people have react aliased to preact-compat so it's included anyway even if it's not needed.

How:

Add a rollup config that aliases react to preact.

Checklist:

  • Documentation
  • Tests N/A I don't really think we need tests for this since we only use createElement and there isn't any seperate src
  • Code complete

@codecov-io
Copy link

codecov-io commented Aug 20, 2017

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          21       21           
  Lines         966      966           
  Branches      260      260           
=======================================
  Hits          873      873           
  Misses         75       75           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba51584...7529914. Read the comment docs.

@tkh44 tkh44 self-requested a review August 20, 2017 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants