Skip to content

Commit 20e3c8f

Browse files
thatblindgeyeTitani
authored andcommitted
chore(Tooltip): updated unit tests (patternfly#9295)
* chore(Tooltip): updated unit tests * Updated mock and tests * Updated based on Austin feedback * Updated integration tests * Removed unused imports * Updated remaining tests using Popper mock * Removed extraenous snapshot test * Removed test * Split out onTooltipHidden test
1 parent 1e1fa7d commit 20e3c8f

File tree

15 files changed

+498
-143
lines changed

15 files changed

+498
-143
lines changed

packages/react-core/src/components/Dropdown/__tests__/Dropdown.test.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ test('renders dropdown', () => {
2222
});
2323

2424
test('passes children', () => {
25-
render(<Dropdown toggle={(toggleRef) => toggle(toggleRef)}>{dropdownChildren}</Dropdown>);
25+
render(
26+
<Dropdown isOpen toggle={(toggleRef) => toggle(toggleRef)}>
27+
{dropdownChildren}
28+
</Dropdown>
29+
);
2630

2731
expect(screen.getByText('Dropdown children')).toBeVisible();
2832
});
@@ -112,7 +116,7 @@ test('passes zIndex to popper', () => {
112116
test('does not pass isOpen to popper by default', () => {
113117
render(<Dropdown toggle={(toggleRef) => toggle(toggleRef)}>{dropdownChildren}</Dropdown>);
114118

115-
expect(screen.getByText('isOpen: undefined')).toBeVisible();
119+
expect(screen.getByText('isVisible: undefined')).toBeVisible();
116120
});
117121

118122
test('passes isOpen to popper', () => {
@@ -122,7 +126,7 @@ test('passes isOpen to popper', () => {
122126
</Dropdown>
123127
);
124128

125-
expect(screen.getByText('isOpen: true')).toBeVisible();
129+
expect(screen.getByText('isVisible: true')).toBeVisible();
126130
});
127131

128132
/* no default tests for callback props
@@ -134,7 +138,7 @@ test('passes onSelect callback', async () => {
134138

135139
const onSelect = jest.fn();
136140
render(
137-
<Dropdown onSelect={onSelect} toggle={(toggleRef) => toggle(toggleRef)}>
141+
<Dropdown isOpen onSelect={onSelect} toggle={(toggleRef) => toggle(toggleRef)}>
138142
{dropdownChildren}
139143
</Dropdown>
140144
);

packages/react-core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.test.tsx.snap

Lines changed: 43 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,40 +2,62 @@
22

33
exports[`match snapshot 1`] = `
44
<DocumentFragment>
5-
<div>
5+
<div
6+
data-testid="mock-wrapper"
7+
>
68
<div
7-
class="customClass"
8-
data-ouia-component-id="dropdown"
9-
data-ouia-component-type="PF5/Dropdown"
10-
data-ouia-safe="true"
11-
data-testid="menu-mock"
9+
data-testid="popper"
1210
>
13-
<div>
11+
<div
12+
class="customClass"
13+
data-ouia-component-id="dropdown"
14+
data-ouia-component-type="PF5/Dropdown"
15+
data-ouia-safe="true"
16+
data-testid="menu-mock"
17+
>
1418
<div>
15-
Dropdown children
19+
<div>
20+
Dropdown children
21+
</div>
1622
</div>
1723
</div>
24+
<div>
25+
Mock item
26+
</div>
27+
<p>
28+
isPlain: true
29+
</p>
30+
<p>
31+
isScrollable: true
32+
</p>
33+
<p>
34+
minWidth: undefined
35+
</p>
1836
</div>
19-
<div>
20-
Mock item
21-
</div>
2237
<p>
23-
isPlain: true
38+
zIndex: 9999
39+
</p>
40+
<p>
41+
isVisible: true
42+
</p>
43+
<p>
44+
enableFlip: undefined
2445
</p>
2546
<p>
26-
isScrollable: true
47+
placement: undefined
48+
</p>
49+
<p>
50+
appendTo: undefined
51+
</p>
52+
<p>
53+
distance: undefined
54+
</p>
55+
<p>
56+
flipBehavior: undefined
2757
</p>
2858
<p>
2959
minWidth: undefined
3060
</p>
31-
</div>
32-
<p>
33-
zIndex: 9999
34-
</p>
35-
<p>
36-
isOpen: true
37-
</p>
38-
<div>
3961
<button>
4062
Dropdown
4163
</button>

packages/react-core/src/components/Tooltip/__tests__/Generated/TooltipArrow.test.tsx

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/react-core/src/components/Tooltip/__tests__/Generated/TooltipContent.test.tsx

Lines changed: 0 additions & 15 deletions
This file was deleted.

packages/react-core/src/components/Tooltip/__tests__/Generated/__snapshots__/TooltipArrow.test.tsx.snap

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/react-core/src/components/Tooltip/__tests__/Generated/__snapshots__/TooltipContent.test.tsx.snap

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)