Skip to content

Commit 989b8da

Browse files
thatblindgeyeTitani
authored andcommitted
fix(Slider): reverted taborder (patternfly#9293)
1 parent 0dd464e commit 989b8da

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

packages/react-core/src/components/Slider/Slider.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -423,16 +423,16 @@ export const Slider: React.FunctionComponent<SliderProps> = ({
423423
{buildSteps()}
424424
</div>
425425
)}
426-
{isInputVisible && inputPosition === 'aboveThumb' && (
427-
<div className={css(styles.sliderValue, styles.modifiers.floating)}>{displayInput()}</div>
428-
)}
429426
{hasTooltipOverThumb ? (
430427
<Tooltip triggerRef={thumbRef} entryDelay={0} content={findAriaTextValue()}>
431428
{thumbComponent}
432429
</Tooltip>
433430
) : (
434431
thumbComponent
435432
)}
433+
{isInputVisible && inputPosition === 'aboveThumb' && (
434+
<div className={css(styles.sliderValue, styles.modifiers.floating)}>{displayInput()}</div>
435+
)}
436436
</div>
437437
{isInputVisible && inputPosition === 'right' && <div className={css(styles.sliderValue)}>{displayInput()}</div>}
438438
{rightActions && <div className={css(styles.sliderActions)}>{rightActions}</div>}

packages/react-core/src/components/Slider/_tests_/__snapshots__/Slider.test.tsx.snap

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,17 @@ exports[`slider renders slider with input above thumb 1`] = `
492492
</div>
493493
</div>
494494
</div>
495+
<div
496+
aria-disabled="false"
497+
aria-label="Value"
498+
aria-valuemax="100"
499+
aria-valuemin="0"
500+
aria-valuenow="50"
501+
aria-valuetext="50"
502+
class="pf-v5-c-slider__thumb"
503+
role="slider"
504+
tabindex="0"
505+
/>
495506
<div
496507
class="pf-v5-c-slider__value pf-m-floating"
497508
>
@@ -526,17 +537,6 @@ exports[`slider renders slider with input above thumb 1`] = `
526537
</div>
527538
</div>
528539
</div>
529-
<div
530-
aria-disabled="false"
531-
aria-label="Value"
532-
aria-valuemax="100"
533-
aria-valuemin="0"
534-
aria-valuenow="50"
535-
aria-valuetext="50"
536-
class="pf-v5-c-slider__thumb"
537-
role="slider"
538-
tabindex="0"
539-
/>
540540
</div>
541541
</div>
542542
</DocumentFragment>

0 commit comments

Comments
 (0)