-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream Sync3 #57
Comments
I'm confused about why It does bring trouble during hybrid parsing. Before rebasing, we can parse a single function or a complete module from hybrid. However, if PrimFunc has no attr name, we cannot auto construct GlobalVars through the name while parsing a single function. I tried to use I'd like to bring the attribute name back. Or we can only allow users to write a complete module in hybrid which may bring extra difficulties in use. |
The reason why The former one belongs to the In our particular case of hybrid parsing, would it be sufficient to return a HybridFunc(which contains the name field) when we run the When we construct IRModule, we can use the stored name as GlobalVar. would love to hear more discussions about the API choice. |
Done. |
Might be a good item after apache/tvm#5372
This PR brings most of the TIR close to what we have in this repo. It might be a good chance to sync after that PR lands. Some noticable highlights include:
Some related changes in this repo:
The text was updated successfully, but these errors were encountered: