Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve verbosity of updating #63

Open
Dentrax opened this issue Nov 3, 2021 · 1 comment
Open

Improve verbosity of updating #63

Dentrax opened this issue Nov 3, 2021 · 1 comment

Comments

@Dentrax
Copy link

Dentrax commented Nov 3, 2021

I think it's worth mentioning to add more verbosity to --update flag since we could not see anything in this first place. How about:

  • How many data will be updated?
  • Which ones are changed?
  • Changed by whom?
  • From which commit to where?
  • etc.
$ tldr --update
# Nothing writes here
@marchersimon
Copy link
Contributor

The first two points are quite doable. The second two would require to interact with the GitHub API, which is a bit more difficult. If you're interested, I've written my own C++ client, where I have implemented the first two points. That's how I did it:

  • Back up all old files
  • Create a hash for every file
  • Download the new files and also create a hash
  • Compare the hashes to see if the file changed

But as I already wrote in #62, this is a client specific issue, so it should be discussed there.

@marchersimon marchersimon transferred this issue from tldr-pages/tldr Nov 3, 2021
@github-actions github-actions bot added the Stale label Jul 14, 2022
@MasterOdin MasterOdin reopened this Aug 14, 2022
@github-actions github-actions bot added the Stale label Aug 30, 2022
@MasterOdin MasterOdin reopened this Oct 13, 2022
@MasterOdin MasterOdin removed the Stale label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants