-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendered output displays "See also:" line twice #431
Comments
Where is the bottom I wonder what the reasoning was behind adding it in the first place was? |
Yep, it's taken from the page content.
Same here, it was implemented in #81 and it seems to be discussed here in tldr-pages/tldr#481. |
I agree that it doesn't really make much sense, as it's usually already within the page. 👍🏻 |
Ahh I see. This feature parses (see `blah`) lines in descriptions, but fails to account for if they are mentioned in the In this case, I would consider this a bug in that feature. |
Expected behavior
Continuing tldr-pages/tldr#5190 (comment) (cc @sbrl).
The rendered output of pages should be displayed as is without a redundant "See also:" entry below the pages.
Actual behavior
Currently, the rendered output of pages displays the "See also:" line twice and in pages using a description like
encfs
it might be useful but still redundant.Also in pages where we add it to an existing line in those cases this additional rendering doesn't take place:
What do you guys think, should we remove it? (IMO removing it will make the rendering consistent with other clients which doesn't do this)
If we decide to go with it, removing the below lines would resolve this issue:
tldr-node-client/lib/render.js
Lines 48 to 52 in 3e65c25
Environment
node --version
):v20.9.0
tldr --version
):3.4.0
The text was updated successfully, but these errors were encountered: