Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add @renie as collaborator #13946

Closed
sebastiaanspeck opened this issue Oct 2, 2024 · 6 comments
Closed

MAINTAINERS: add @renie as collaborator #13946

sebastiaanspeck opened this issue Oct 2, 2024 · 6 comments
Labels
community Issues/PRs dealing with role changes and community organization.

Comments

@sebastiaanspeck
Copy link
Member

sebastiaanspeck commented Oct 2, 2024

Hi, @renie! You seem to be enjoying contributing to the tldr-pages project.
You now have had over more than five distinct pull requests merged!
That qualifies you to become a collaborator in this repository, as explained in our community roles documentation.

As a collaborator, you will have commit access to the repository.
That means you can merge pull requests, label and close issues, and perform various other maintenance tasks that are needed here and there.
Of course, all of this is voluntary — you're welcome to contribute to the project in whatever ways suit your liking.

If you do decide to start performing maintenance tasks, though, we only ask you to get familiar with the maintainer's guide.

So, what do you say? Can we add you as a collaborator? And since you have contributed to Portuguese Brazilian pages, would you like to be added as CODEOWNER? If so, you will get added as a reviewer to all PR's affecting Portuguese Brazilian pages

Either way, thanks for all your work so far!

Note

It is required to have two-factor authentication (2FA) enabled for your GitHub account to be added as a collaborator to the tldr-pages/tldr repository.

@kbdharun
Copy link
Member

kbdharun commented Oct 3, 2024

Hi @sebastiaanspeck are you sure the username is right, I can't find the PRs merged under their account.

@sebastiaanspeck sebastiaanspeck changed the title MAINTAINERS: add @lenie as collaborator MAINTAINERS: add @renie as collaborator Oct 3, 2024
@sebastiaanspeck
Copy link
Member Author

Hi @sebastiaanspeck are you sure the username is right, I can't find the PRs merged under their account.

You're right, a small typo. I meant @renie

@renie
Copy link
Member

renie commented Oct 3, 2024

That sounds very nice, @sebastiaanspeck ! Thank you very much for the invitation!
And sure, it will be a pleasure and an honor to become contributor, and to be added as CODEOWNER!

PS.: I found it funny that you've mentioned me as lenie. I've got some people spelling/speaking it not correctly but this was a totally new one 😄

@sebastiaanspeck
Copy link
Member Author

That sounds very nice, @sebastiaanspeck ! Thank you very much for the invitation!
And sure, it will be a pleasure and an honor to become contributor, and to be added as CODEOWNER!

PS.: I found it funny that you've mentioned me as lenie. I've got some people spelling/speaking it not correctly but this was a totally new one 😄

I will send you an invite, feel free to close this issue with a PR that adds you to the list of repository collaborators and that adds you to pages.pt_BR as CODEOWNER.

@renie
Copy link
Member

renie commented Oct 3, 2024

The PR is opened. Would you please have a look at it before I merge it, @sebastiaanspeck ?

@sebastiaanspeck
Copy link
Member Author

The PR is opened. Would you please have a look at it before I merge it, @sebastiaanspeck ?

Please never merge a PR without any approvals, I will look at it.

@kbdharun kbdharun closed this as completed Oct 3, 2024
@kbdharun kbdharun added the community Issues/PRs dealing with role changes and community organization. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

No branches or pull requests

3 participants