Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSIS uninstaller must not delete the installation folder #101

Closed
tlecomte opened this issue Feb 16, 2019 · 1 comment
Closed

NSIS uninstaller must not delete the installation folder #101

tlecomte opened this issue Feb 16, 2019 · 1 comment
Labels
Bug report installer windows

Comments

@tlecomte
Copy link
Owner

The NSIS uninstaller for Windows uses RMDir /r "$INSTDIR" to cleanup the installation folder:

friture/installer/friture-setup.nsi

Line 150 in fb6ac23

RMDir /r "$INSTDIR"

This is not safe, since the user might have chosen to install Friture in a folder that already contains other programs or data. This problem is documented in NSIS documentation: https://nsis.sourceforge.io/Reference/RMDir and a alternative is offered here: https://nsis.sourceforge.io/Uninstall_only_installed_files
@tlecomte tlecomte mentioned this issue Mar 10, 2019
Closed
@tlecomte tlecomte mentioned this issue Oct 29, 2019
Merged
@tlecomte
Copy link
Owner Author

This will be fixed by the move to a MSI installer instead of NSIS. This new installer is available in Friture 0.40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report installer windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tlecomte