Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.mjs should be added as a default extension #170

Closed
tleunen opened this issue May 9, 2017 · 3 comments
Closed

.mjs should be added as a default extension #170

tleunen opened this issue May 9, 2017 · 3 comments

Comments

@tleunen
Copy link
Owner

tleunen commented May 9, 2017

.mjs has been added into Babel so we have to update our list of extensions too.

It would also make sense to reuse the list from babel-core (only in v7): https://github.com/babel/babel/blob/7.0/packages/babel-core/src/index.js#L44
@fatfisz
Copy link
Contributor

fatfisz commented May 10, 2017

In theory this could be imported from babel-core, but does it make sense to make it a dependency?

Or should it just be copy-pasted?

@tleunen
Copy link
Owner Author

tleunen commented May 10, 2017

Hmm yeah.. I guess we can just copy/paste it. It shouldn't change very often anyway :)

@fatfisz fatfisz mentioned this issue May 10, 2017
Merged
@fatfisz
Copy link
Contributor

fatfisz commented May 15, 2017 •
edited
Loading

Feature added in #172.

@fatfisz fatfisz closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tleunen @fatfisz