This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Add CardMedia component #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import React, { PropTypes } from 'react'; | ||
| import classNames from 'classnames'; | ||
|
|
||
| const CardMedia = (props) => { |
There was a problem hiding this comment.
Sounds like a good candidate for reusing the basicClassCreator helper.
You can see these 2 as an example: https://github.com/tleunen/react-mdl/blob/master/src/Card/index.js#L4-L5
You can keep the tests though
There was a problem hiding this comment.
That did simplify things greatly.
|
Thanks @durandj! |
This utilizes the MDL mdl-card__media class as specified in the MDL specification. Simplify CardMedia component CardMedia doesn't seem to have any special functionality so the basicClassCreator could be used to implement all the functionality with less code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes the MDL mdl-card__media class as specified in the MDL
specification. While not strictly needed it does make for more semantic markup.