Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Radio not working in Chrome #180

Closed
Gregoor opened this issue Jan 6, 2016 · 3 comments
Closed

Radio not working in Chrome #180

Gregoor opened this issue Jan 6, 2016 · 3 comments
Labels

Comments

@Gregoor
Copy link
Contributor

Gregoor commented Jan 6, 2016

Neither in the docs (http://tleunen.github.io/react-mdl/#/toggles) nor does it work for me locally. Tested in Chrome, without extensions.

Strangely enough it seems to work in FF and Edge.

@tleunen tleunen added the bug label Jan 6, 2016
@tleunen
Copy link
Owner

tleunen commented Jan 6, 2016

Good catch. This is because of the empty onChange callback.
Either you have to get the changed value and apply it on the radio, or you can get the value with another way (using ref for example) and in that case you don't need the callback.
I'll fix the doc.

@Gregoor
Copy link
Contributor Author

Gregoor commented Jan 6, 2016

Thanks for getting back to me so quickly (also big thanks for the library, my HTML looks so much better without all those mdl-classes :) ).

I noticed that the change is happening in the underlying input elements, the MDL classes are just not updated. If that's also what you're talking about would I then have to fix the MDL classes when changes happen?

@tleunen
Copy link
Owner

tleunen commented Jan 6, 2016

the mdl class is-checked should be updated even if you don't specify the change callback. But it will result in the small warning explained in this PR #181

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants