Skip to content

Commit 43f8b10

Browse files
committed
Angular v1.2.20 support, closes item:783
Manually enable Angular CSP mode as auto-detection triggers a harmless, though nonetheless annoying CSP error. CSP detection has also proved to be brittle. Override Angular's Bower main block to include `angular-csp.css` so that Wiredep can inject it for us. See: angular/angular.js#8191
1 parent 3343805 commit 43f8b10

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

app/index.html

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
<!doctype html>
2-
<html ng-app="lmisChromeApp">
2+
<html ng-app="lmisChromeApp" ng-csp>
33
<head>
44
<meta charset="utf-8">
55
<title>Nigeria LMIS</title>
66
<meta name="viewport" content="user-scalable=no, initial-scale=1, maximum-scale=1, minimum-scale=1, width=device-width, height=device-height">
77
<!-- build:css styles/vendor.css -->
88
<!-- bower:css -->
9+
<link rel="stylesheet" href="bower_components/angular/angular-csp.css" />
910
<link rel="stylesheet" href="bower_components/font-awesome/css/font-awesome.css" />
1011
<link rel="stylesheet" href="bower_components/bootstrap-css-only/css/bootstrap.css" />
1112
<link rel="stylesheet" href="bower_components/bootstrap-theme-cosmo/cosmo.min.css" />

bower.json

+11-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "lmis-chrome",
33
"version": "0.10.4",
44
"dependencies": {
5-
"angular": "1.2.19",
5+
"angular": "~1.2.20",
66
"angular-bootstrap": "~0.11.0",
77
"font-awesome": "~4.1.0",
88
"angular-ui-router": "~0.2.10",
@@ -12,11 +12,11 @@
1212
"bootstrap-theme-cosmo": "tlvince/bootstrap-theme-cosmo#4c161a6bf5bebe0ecfbef0771e053c8c5c2698c9",
1313
"angularjs-nvd3-directives": "~0.0.7",
1414
"angular-growl-v2": "~0.6.1",
15-
"angular-animate": "1.2.19",
15+
"angular-animate": "~1.2.20",
1616
"chrome-platform-analytics": "GoogleChrome/chrome-platform-analytics#ea84600d1251fee9dd3fe274780f385d5d1c03f1"
1717
},
1818
"devDependencies": {
19-
"angular-mocks": "1.2.19",
19+
"angular-mocks": "~1.2.20",
2020
"jasmine-as-promised": "~0.0.8",
2121
"es5-shim": "~3.4.0"
2222
},
@@ -36,5 +36,13 @@
3636
"private": true,
3737
"resolutions": {
3838
"d3": "~3.4.1"
39+
},
40+
"overrides": {
41+
"angular": {
42+
"main": [
43+
"angular.js",
44+
"angular-csp.css"
45+
]
46+
}
3947
}
4048
}

0 commit comments

Comments
 (0)