Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for async matchers #169

Open
bertBruynooghe opened this issue Oct 16, 2018 · 4 comments
Open

support for async matchers #169

bertBruynooghe opened this issue Oct 16, 2018 · 4 comments

Comments

@bertBruynooghe
Copy link

Feature request

Current behavior?

e.g. await expectAsync(new Promise... triggers 'expectAsync' is not defined

What is the expected behavior?
At least it should pass wit

Please mention your node.js, eslint-plugin-jasmine and operating system version.
Node: 9
eslint-plugin-jasmine: 2.10.1
os: MacOS, docker node:9-alpine
jasmine 3.2.0

@sidvishnoi
Copy link

I think this would be handled by eslint globals instead.

@bertBruynooghe
Copy link
Author

@sidvishnoi Can you please elaborate? Is there a way we could it get working now?

@sidvishnoi
Copy link

This project's readme says:

ESLint itself provides a Jasmine environment for Jasmine's global variables

meaning globals are not handled here.

So, we can add to following to .eslintrc.yml:

globals:
  expectAsync: true

It would be a workaround until sindresorhus/globals#152 is merged and included in eslint

@bertBruynooghe
Copy link
Author

ok, thx, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants