Comparison of unsigned size_t with 0 creates unreachable code

[bact]

What happened

Under
Apple LLVM version 8.0.0 (clang-800.0.38)
Target: x86_64-apple-darwin15.6.0

make put this warning

trietool.c:128:13: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
if (res < 0)

1 warning generated.

Possible cause

• res is size_t, returned from iconv()
• the intention is to checked if there is error occur or not during iconv() call, if there is iconv() will return -1
• size_t [which is unsigned] < 0 is always false

Proposed fix

128c128
<     if (res < 0)

---
>     if (res == (size_t) -1)

[bact]

Sorry. Duplicate of Issue #3

Close.