Skip to content

Commit 5289625

Browse files
tmandrytmandry
authored
Rollup merge of rust-lang#65498 - SimonSapin:plugin-help, r=Centril
Plugins deprecation: don’t suggest simply removing the attribute Building Servo with a recent Nightly produces: ```rust warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See rust-lang#29597 --> components/script/lib.rs:14:1 | 14 | #![plugin(script_plugins)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute | = note: `#[warn(deprecated)]` on by default ``` First, linking to rust-lang#29597 is not ideal since there is pretty much no discussion there of the deprecation and what can be used instead. This PR changes the link to the deprecation PR which does have more discussion. Second, the “remove this attribute” suggestion is rather unhelpful. Just because a feature is deprecated doesn’t mean that simply removing its use without a replacement is acceptable. In the case of custom lint, there is no replacement available. Prefixing a message with “help:” when telling users that they’re screwed honestly feels disrespectful. This PR also changes the message to be more factual.
2 parents 554d46f + 71b0049 commit 5289625

33 files changed

+84
-78
lines changed

Diff for: ‎src/libsyntax/feature_gate/builtin_attrs.rs

+8-2
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,10 @@ pub const BUILTIN_ATTRIBUTES: &[BuiltinAttribute] = &[
286286
(
287287
sym::plugin_registrar, Normal, template!(Word),
288288
Gated(
289-
Stability::Deprecated("https://github.com/rust-lang/rust/issues/29597", None),
289+
Stability::Deprecated(
290+
"https://github.com/rust-lang/rust/pull/64675",
291+
Some("may be removed in a future compiler version"),
292+
),
290293
sym::plugin_registrar,
291294
"compiler plugins are deprecated",
292295
cfg_fn!(plugin_registrar)
@@ -295,7 +298,10 @@ pub const BUILTIN_ATTRIBUTES: &[BuiltinAttribute] = &[
295298
(
296299
sym::plugin, CrateLevel, template!(List: "name|name(args)"),
297300
Gated(
298-
Stability::Deprecated("https://github.com/rust-lang/rust/issues/29597", None),
301+
Stability::Deprecated(
302+
"https://github.com/rust-lang/rust/pull/64675",
303+
Some("may be removed in a future compiler version"),
304+
),
299305
sym::plugin,
300306
"compiler plugins are deprecated",
301307
cfg_fn!(plugin)

Diff for: ‎src/test/ui-fulldeps/gated-plugin.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ LL | #![plugin(attr_plugin_test)]
77
= note: for more information, see https://github.com/rust-lang/rust/issues/29597
88
= help: add `#![feature(plugin)]` to the crate attributes to enable
99

10-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
10+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
1111
--> $DIR/gated-plugin.rs:3:1
1212
|
1313
LL | #![plugin(attr_plugin_test)]
14-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
14+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
1515
|
1616
= note: `#[warn(deprecated)]` on by default
1717

Diff for: ‎src/test/ui-fulldeps/issue-15778-fail.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/issue-15778-fail.rs:6:1
33
|
44
LL | #![plugin(lint_for_crate)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/issue-15778-pass.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/issue-15778-pass.rs:8:1
33
|
44
LL | #![plugin(lint_for_crate_rpass)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/issue-40001.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/issue-40001.rs:6:1
33
|
44
LL | #![plugin(issue_40001_plugin)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/lint-group-plugin-deny-cmdline.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/lint-group-plugin-deny-cmdline.rs:7:1
33
|
44
LL | #![plugin(lint_group_plugin_test)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/lint-group-plugin.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/lint-group-plugin.rs:6:1
33
|
44
LL | #![plugin(lint_group_plugin_test)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/lint-plugin-cmdline-allow.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/lint-plugin-cmdline-allow.rs:8:1
33
|
44
LL | #![plugin(lint_plugin_test)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/lint-plugin-deny-attr.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/lint-plugin-deny-attr.rs:5:1
33
|
44
LL | #![plugin(lint_plugin_test)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/lint-plugin-deny-cmdline.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/lint-plugin-deny-cmdline.rs:6:1
33
|
44
LL | #![plugin(lint_plugin_test)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/lint-plugin-forbid-attrs.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ LL | #![forbid(test_lint)]
77
LL | #[allow(test_lint)]
88
| ^^^^^^^^^ overruled by previous forbid
99

10-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
10+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
1111
--> $DIR/lint-plugin-forbid-attrs.rs:5:1
1212
|
1313
LL | #![plugin(lint_plugin_test)]
14-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
14+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
1515
|
1616
= note: `#[warn(deprecated)]` on by default
1717

Diff for: ‎src/test/ui-fulldeps/lint-plugin-forbid-cmdline.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ LL | #[allow(test_lint)]
66
|
77
= note: `forbid` lint level was set on command line
88

9-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
9+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
1010
--> $DIR/lint-plugin-forbid-cmdline.rs:6:1
1111
|
1212
LL | #![plugin(lint_plugin_test)]
13-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
13+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
1414
|
1515
= note: `#[warn(deprecated)]` on by default
1616

Diff for: ‎src/test/ui-fulldeps/lint-plugin.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/lint-plugin.rs:5:1
33
|
44
LL | #![plugin(lint_plugin_test)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/lint-tool-cmdline-allow.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ warning: lint name `test_lint` is deprecated and does not have an effect anymore
22
|
33
= note: requested on the command line with `-A test_lint`
44

5-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
5+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
66
--> $DIR/lint-tool-cmdline-allow.rs:8:1
77
|
88
LL | #![plugin(lint_tool_test)]
9-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
9+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
1010
|
1111
= note: `#[warn(deprecated)]` on by default
1212

Diff for: ‎src/test/ui-fulldeps/lint-tool-test.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ warning: lint name `test_lint` is deprecated and may not have an effect in the f
3232
LL | #![cfg_attr(foo, warn(test_lint))]
3333
| ^^^^^^^^^ help: change it to: `clippy::test_lint`
3434

35-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
35+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
3636
--> $DIR/lint-tool-test.rs:6:1
3737
|
3838
LL | #![plugin(lint_tool_test)]
39-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
39+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
4040
|
4141
= note: `#[warn(deprecated)]` on by default
4242

Diff for: ‎src/test/ui-fulldeps/llvm-pass-plugin.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/llvm-pass-plugin.rs:6:1
33
|
44
LL | #![plugin(llvm_pass_plugin)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/lto-syntax-extension.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/lto-syntax-extension.rs:9:1
33
|
44
LL | #![plugin(lto_syntax_extension_plugin)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/macro-crate-rlib.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ error[E0457]: plugin `rlib_crate_test` only found in rlib format, but must be av
44
LL | #![plugin(rlib_crate_test)]
55
| ^^^^^^^^^^^^^^^
66

7-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
7+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
88
--> $DIR/macro-crate-rlib.rs:6:1
99
|
1010
LL | #![plugin(rlib_crate_test)]
11-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
11+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
1212
|
1313
= note: `#[warn(deprecated)]` on by default
1414

Diff for: ‎src/test/ui-fulldeps/outlive-expansion-phase.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/outlive-expansion-phase.rs:6:1
33
|
44
LL | #![plugin(outlive_expansion_phase)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/plugin-args-1.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/plugin-args-1.rs:6:1
33
|
44
LL | #![plugin(plugin_args)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/plugin-args-2.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/plugin-args-2.rs:6:1
33
|
44
LL | #![plugin(plugin_args())]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/plugin-args-3.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/plugin-args-3.rs:6:1
33
|
44
LL | #![plugin(plugin_args(hello(there), how(are="you")))]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/plugin-attr-register-deny.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/plugin-attr-register-deny.rs:5:1
33
|
44
LL | #![plugin(attr_plugin_test)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui-fulldeps/plugin-reexport.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ note: consider marking `mac` as `pub` in the imported module
1010
LL | pub use mac as reexport;
1111
| ^^^^^^^^^^^^^^^
1212

13-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
13+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
1414
--> $DIR/plugin-reexport.rs:6:1
1515
|
1616
LL | #![plugin(attr_plugin_test)]
17-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
17+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
1818
|
1919
= note: `#[warn(deprecated)]` on by default
2020

Diff for: ‎src/test/ui-fulldeps/roman-numerals-macro.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
1+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
22
--> $DIR/roman-numerals-macro.rs:6:1
33
|
44
LL | #![plugin(roman_numerals)]
5-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
66
|
77
= note: `#[warn(deprecated)]` on by default
88

Diff for: ‎src/test/ui/feature-gate/issue-43106-gating-of-builtin-attrs.stderr

+12-12
Original file line numberDiff line numberDiff line change
@@ -186,43 +186,43 @@ LL | mod inner { #![macro_escape] }
186186
|
187187
= help: consider an outer attribute, `#[macro_use]` mod ...
188188

189-
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
189+
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
190190
--> $DIR/issue-43106-gating-of-builtin-attrs.rs:219:17
191191
|
192192
LL | mod inner { #![plugin_registrar] }
193-
| ^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
193+
| ^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
194194
|
195195
= note: `#[warn(deprecated)]` on by default
196196

197-
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
197+
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
198198
--> $DIR/issue-43106-gating-of-builtin-attrs.rs:224:5
199199
|
200200
LL | #[plugin_registrar] struct S;
201-
| ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
201+
| ^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
202202

203-
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
203+
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
204204
--> $DIR/issue-43106-gating-of-builtin-attrs.rs:227:5
205205
|
206206
LL | #[plugin_registrar] type T = S;
207-
| ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
207+
| ^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
208208

209-
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
209+
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
210210
--> $DIR/issue-43106-gating-of-builtin-attrs.rs:230:5
211211
|
212212
LL | #[plugin_registrar] impl S { }
213-
| ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
213+
| ^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
214214

215-
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
215+
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
216216
--> $DIR/issue-43106-gating-of-builtin-attrs.rs:216:1
217217
|
218218
LL | #[plugin_registrar]
219-
| ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
219+
| ^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
220220

221-
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
221+
warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
222222
--> $DIR/issue-43106-gating-of-builtin-attrs.rs:40:1
223223
|
224224
LL | #![plugin_registrar]
225-
| ^^^^^^^^^^^^^^^^^^^^ help: remove this attribute
225+
| ^^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
226226

227227
warning: use of deprecated attribute `crate_id`: no longer used.
228228
--> $DIR/issue-43106-gating-of-builtin-attrs.rs:90:1

Diff for: ‎src/test/ui/feature-gates/feature-gate-plugin.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ LL | #![plugin(foo)]
77
= note: for more information, see https://github.com/rust-lang/rust/issues/29597
88
= help: add `#![feature(plugin)]` to the crate attributes to enable
99

10-
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597
10+
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
1111
--> $DIR/feature-gate-plugin.rs:3:1
1212
|
1313
LL | #![plugin(foo)]
14-
| ^^^^^^^^^^^^^^^ help: remove this attribute
14+
| ^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
1515
|
1616
= note: `#[warn(deprecated)]` on by default
1717

0 commit comments

Comments
 (0)