Skip to content

Commit e16b322

Browse files
authored
Rollup merge of rust-lang#67351 - Mark-Simulacrum:always-channel, r=pietroalbini
Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
2 parents 0bbfb8e + f365dbc commit e16b322

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/ci/run.sh

+6-1
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,13 @@ RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.parallel-compiler"
4646
# FIXME: need a scheme for changing this `nightly` value to `beta` and `stable`
4747
# either automatically or manually.
4848
export RUST_RELEASE_CHANNEL=nightly
49+
50+
# Always set the release channel for bootstrap; this is normally not important (i.e., only dist
51+
# builds would seem to matter) but in practice bootstrap wants to know whether we're targeting
52+
# master, beta, or stable with a build to determine whether to run some checks (notably toolstate).
53+
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --release-channel=$RUST_RELEASE_CHANNEL"
54+
4955
if [ "$DEPLOY$DEPLOY_ALT" = "1" ]; then
50-
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --release-channel=$RUST_RELEASE_CHANNEL"
5156
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-llvm-static-stdcpp"
5257
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.remap-debuginfo"
5358
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --debuginfo-level-std=1"

0 commit comments

Comments
 (0)