Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag releases #388

Closed
tmc opened this issue Dec 1, 2023 · 2 comments
Closed

tag releases #388

tmc opened this issue Dec 1, 2023 · 2 comments

Comments

@tmc
Copy link
Owner

tmc commented Dec 1, 2023

We're going to begin tagging releases once the current embeddings refactor (#379) is complete.

@eliben
Copy link
Collaborator

eliben commented Dec 1, 2023

The refactoring of #379 is almost complete - and I think it's alright to tag a release.

The remaining providers are:

  • tei: I added a comment on this in vectorstores: add Milvus #352 - as it was just added very recently. Perhaps it can be adapted to the current interface

  • huggingface: this one is a bit harder because its LLM.CreateEmbedding doesn't have the same signature as the other providers. @tmc you did some work on the huggingface provider, WDYT? Can it be refactored to present the same interface? The model can be chosen when the client is created, I don't know if people really expect to call CreateEmbedding on the same client with different models

@tmc
Copy link
Owner Author

tmc commented Dec 13, 2023

thanks @eliben, I had missed that comment. We went ahead and got v0.1.0 out but will push a new release once this refactor is complete. Closing this for now.

@tmc tmc closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants