Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_GraphicsMixin bug #28

Closed
jebu75 opened this issue Aug 23, 2015 · 4 comments
Closed

_GraphicsMixin bug #28

jebu75 opened this issue Aug 23, 2015 · 4 comments
Labels
bug

Comments

@jebu75
Copy link

jebu75 commented Aug 23, 2015

In _GraphicsMixin on lines 289 and 290 there is no need for the PopupTemplate class. I believe this is handled by the underlying map.

Removing line 289 and changing 290 as follows correctly displays the configured infoTemplate on the search result graphic:

graphic.setInfoTemplate(this.infoTemplate);

This has been tested successfully in one of my applications.
@tmcgee tmcgee added the bug label Aug 23, 2015
@tmcgee
Copy link
Owner

tmcgee commented Aug 23, 2015

Thanks. The same change would need to be applied at lines 342 and 343 for the selected graphics.

@jebu75
Copy link
Author

jebu75 commented Aug 23, 2015

Good catch, will do! I'll create a PR later today.

@tmcgee
Copy link
Owner

tmcgee commented Aug 29, 2015

@jebu75 Is it "later today" yet? ;)

@tmcgee
Copy link
Owner

tmcgee commented Sep 18, 2015

@jebu75 got a PR?

@tmcgee tmcgee closed this as completed in cff8e68 Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmcgee @jebu75