Skip to content

Commit b1e2a66

Browse files
raulcdkou
authored andcommitted
apacheGH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Docker on Windows on archery (apache#41120)
### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#41119 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent ecd69e3 commit b1e2a66

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

dev/archery/archery/docker/core.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def _build(service, use_cache):
311311
self._execute_docker("buildx", "build", *args)
312312
elif self.config.using_docker:
313313
# better for caching
314-
if self.config.debug:
314+
if self.config.debug and os.name != "nt":
315315
args.append("--progress=plain")
316316
for k, v in service['build'].get('args', {}).items():
317317
args.extend(['--build-arg', '{}={}'.format(k, v)])
@@ -324,7 +324,7 @@ def _build(service, use_cache):
324324
])
325325
self._execute_docker("build", *args)
326326
else:
327-
if self.config.debug:
327+
if self.config.debug and os.name != "nt":
328328
args.append("--progress=plain")
329329
self._execute_compose("build", *args, service['name'])
330330

0 commit comments

Comments
 (0)