Skip to content

Commit b3ef16a

Browse files
joemarshallkoujorisvandenbossche
authored andcommitted
apacheGH-23221: [C++] Add support for building with Emscripten (apache#37821)
Split from apache#37696 This is just the cmake changes to enable building on emscripten. Changes are: 1) Support for target system "emscripten" 2) Cmake preset for building libarrow ` ninja-release-python-emscripten` (same as `ninja-release-python`, but with emscripten support) 3) Override file for cmake on emscripten, to set various build parameters that need setting to make it build there. 4) Changes in pyarrow cmake so it works if you are building libarrow as shared library, and also an option to enable the cmake file there to just dump the current arrow configuration, which is useful for cross-compile builds. * Closes: apache#23221 Lead-authored-by: Joe Marshall <joe.marshall@nottingham.ac.uk> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent 06ce746 commit b3ef16a

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

ci/scripts/cpp_build.sh

-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ else
166166
-DARROW_USE_CCACHE=${ARROW_USE_CCACHE:-ON} \
167167
-DARROW_USE_GLOG=${ARROW_USE_GLOG:-OFF} \
168168
-DARROW_USE_LD_GOLD=${ARROW_USE_LD_GOLD:-OFF} \
169-
-DARROW_USE_LLD=${ARROW_USE_LLD:-OFF} \
170169
-DARROW_USE_MOLD=${ARROW_USE_MOLD:-OFF} \
171170
-DARROW_USE_PRECOMPILED_HEADERS=${ARROW_USE_PRECOMPILED_HEADERS:-OFF} \
172171
-DARROW_USE_STATIC_CRT=${ARROW_USE_STATIC_CRT:-OFF} \

cpp/cmake_modules/SetupCxxFlags.cmake

-1
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,6 @@ if("${BUILD_WARNING_LEVEL}" STREQUAL "CHECKIN")
314314
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall")
315315
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wextra")
316316
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wdocumentation")
317-
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DARROW_WARN_DOCUMENTATION")
318317
if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
319318
# size_t is 32 bit in Emscripten wasm32 - ignore conversion errors
320319
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-shorten-64-to-32")

0 commit comments

Comments
 (0)