Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coordinate properties for times and heartRates #47

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Add coordinate properties for times and heartRates #47

merged 1 commit into from
Mar 31, 2021

Conversation

RalucaNicola
Copy link

Addresses issue #29.

This PR moves the coordTimes and heartRates properties into a parent property coordinateProperties:

  • kml: coordTimes is moved into coordinateProperties.times
  • gpx: coordTimes and heartRates are moved into coordinateProperties.times and coordinateProperties.heartRates
  • tcx: coordTimes and heartRates are moved into coordinateProperties.times and coordinateProperties.heartRates

@RalucaNicola
Copy link
Author

Finally made a PR @tmcw. When you get a chance, let me know if my approach is going in the right direction here :) thanks!

@tmcw
Copy link
Collaborator

tmcw commented Mar 30, 2021

Ah, sorry I missed this notification! Reviewing this today.

tmcw
tmcw approved these changes Mar 31, 2021
View reviewed changes
Copy link
Collaborator

@tmcw tmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Perfect! Took me a little while to wrap my head around the gpx implementation, but it seems pretty ideal. Thanks, merging.

@tmcw tmcw merged commit 5e3958b into placemark:master Mar 31, 2021
@RalucaNicola
Copy link
Author

awesome, thanks for reviewing 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmcw tmcw tmcw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalucaNicola @tmcw