Skip to content

Commit e27a232

Browse files
OwnageIsMagicjozkee
authored andcommittedJan 23, 2024
Use corresponding exception message, if null passed (dotnet#90505)
* use corresponding exception message if null passed * fix * review fixes * fix tests * do not use default message if null passed for SystemException, ApplicationException, IOException * change COMException default message --------- Co-authored-by: David Cantú <dacantu@microsoft.com>
1 parent b96130a commit e27a232

File tree

99 files changed

+281
-286
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

99 files changed

+281
-286
lines changed
 

‎src/libraries/Microsoft.Extensions.Hosting.Abstractions/src/HostAbortedException.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public HostAbortedException() : base(SR.HostAbortedExceptionMessage) { }
3434
/// The caller of this constructor is required to ensure that this string has been localized for the
3535
/// current system culture.
3636
/// </remarks>
37-
public HostAbortedException(string? message) : base(message) { }
37+
public HostAbortedException(string? message) : base(message ?? SR.HostAbortedExceptionMessage) { }
3838

3939
/// <summary>
4040
/// Initializes a new instance of the <see cref="HostAbortedException"/> class
@@ -52,6 +52,6 @@ public HostAbortedException(string? message) : base(message) { }
5252
/// The caller of this constructor is required to ensure that this string has been localized for the
5353
/// current system culture.
5454
/// </remarks>
55-
public HostAbortedException(string? message, Exception? innerException) : base(message, innerException) { }
55+
public HostAbortedException(string? message, Exception? innerException) : base(message ?? SR.HostAbortedExceptionMessage, innerException) { }
5656
}
5757
}

‎src/libraries/System.Composition.Runtime/src/System/Composition/Hosting/CompositionFailedException.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public CompositionFailedException()
2222
/// </summary>
2323
/// <param name="message">The exception message.</param>
2424
public CompositionFailedException(string message)
25-
: base(message)
25+
: base(message ?? SR.CompositionFailedDefaultExceptionMessage)
2626
{ }
2727

2828
/// <summary>
@@ -31,7 +31,7 @@ public CompositionFailedException(string message)
3131
/// <param name="message">The exception message.</param>
3232
/// <param name="innerException">The inner exception.</param>
3333
public CompositionFailedException(string message, Exception innerException)
34-
: base(message, innerException)
34+
: base(message ?? SR.CompositionFailedDefaultExceptionMessage, innerException)
3535
{ }
3636
}
3737
}

0 commit comments

Comments
 (0)
Please sign in to comment.