Skip to content

Commit 1f580a2

Browse files
committed
!squash test_server cleanup
1 parent 1344d29 commit 1f580a2

File tree

1 file changed

+33
-13
lines changed

1 file changed

+33
-13
lines changed

tests/test_server.py

Lines changed: 33 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,12 @@ def on_init(server: Server) -> None:
238238
called_with.append(server)
239239

240240
myserver = Server(socket_name="test_on_init", on_init=on_init)
241-
assert len(called_with) == 1
242-
assert called_with[0] is myserver
241+
try:
242+
assert len(called_with) == 1
243+
assert called_with[0] is myserver
244+
finally:
245+
if myserver.is_alive():
246+
myserver.kill()
243247

244248

245249
def test_socket_name_factory(server: Server) -> None:
@@ -252,13 +256,23 @@ def socket_name_factory() -> str:
252256
return name
253257

254258
myserver = Server(socket_name_factory=socket_name_factory)
255-
assert myserver.socket_name == "test_socket_0"
256-
assert socket_names == ["test_socket_0"]
257-
258-
# Creating another server should use factory again
259-
myserver2 = Server(socket_name_factory=socket_name_factory)
260-
assert myserver2.socket_name == "test_socket_1"
261-
assert socket_names == ["test_socket_0", "test_socket_1"]
259+
try:
260+
assert myserver.socket_name == "test_socket_0"
261+
assert socket_names == ["test_socket_0"]
262+
263+
# Creating another server should use factory again
264+
myserver2 = Server(socket_name_factory=socket_name_factory)
265+
try:
266+
assert myserver2.socket_name == "test_socket_1"
267+
assert socket_names == ["test_socket_0", "test_socket_1"]
268+
finally:
269+
if myserver2.is_alive():
270+
myserver2.kill()
271+
finally:
272+
if myserver.is_alive():
273+
myserver.kill()
274+
if myserver2.is_alive():
275+
myserver2.kill()
262276

263277

264278
def test_socket_name_precedence(server: Server) -> None:
@@ -271,8 +285,14 @@ def socket_name_factory() -> str:
271285
socket_name="explicit_name",
272286
socket_name_factory=socket_name_factory,
273287
)
274-
assert myserver.socket_name == "explicit_name"
275-
276-
# Without socket_name, factory is used
277288
myserver2 = Server(socket_name_factory=socket_name_factory)
278-
assert myserver2.socket_name == "from_factory"
289+
try:
290+
assert myserver.socket_name == "explicit_name"
291+
292+
# Without socket_name, factory is used
293+
assert myserver2.socket_name == "from_factory"
294+
finally:
295+
if myserver.is_alive():
296+
myserver.kill()
297+
if myserver2.is_alive():
298+
myserver2.kill()

0 commit comments

Comments
 (0)