fix!(Window.split_window): Detach by default

Author: tony

src/libtmux/window.py

@@ -177,7 +177,7 @@ def split_window(
         self,
         target: t.Optional[t.Union[int, str]] = None,
         start_directory: t.Optional[str] = None,
-        attach: bool = True,
+        attach: bool = False,
         vertical: bool = True,
         shell: t.Optional[str] = None,
         percent: t.Optional[int] = None,
@@ -220,6 +220,10 @@ def split_window(
         By default, this will make the window the pane is created in
         active. To remain on the same window and split the pane in another
         target window, pass in ``attach=False``.
+
+        .. versionchanged:: 0.28.0
+
+           ``attach`` default changed from ``True`` to ``False``.
         """
         tmux_formats = ["#{pane_id}" + FORMAT_SEPARATOR]
 

tests/test_dataclasses.py

@@ -40,11 +40,9 @@ def test_pane(
 
     __window = __session.attached_window
     __window.split_window()
-    __window.split_window()
+    __pane = __window.split_window()
     __window.select_layout("main-vertical")
 
-    __pane = __window.attached_pane
-
     assert __pane is not None
     assert __pane.pane_id is not None