Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for other python versions #176

Closed
freemansw1 opened this issue Sep 9, 2022 · 4 comments
Closed

Add tests for other python versions #176

freemansw1 opened this issue Sep 9, 2022 · 4 comments
Assignees
Labels
enhancement Addition of new features, or improved functionality of existing features
Milestone

Comments

@freemansw1
Copy link
Member

Currently, we only run tests on the latest versions of Python and our dependent libraries. We should probably expand this to test multiple python versions. This should be doable through GitHub Actions, similar to how Metpy has done it.

I'm inclined to have us test the latest minor release for every Python version that we support (we are >=3.6 now). It might also be a good idea to test multiple versions of our libraries, but I see a less clear path forward on that.

@mgrover1 given your immense experience here, I'd be interested in hearing your opinion on this!

@freemansw1 freemansw1 added the enhancement Addition of new features, or improved functionality of existing features label Sep 9, 2022
@JuliaKukulies
Copy link
Member

That sounds like a very good idea @freemansw1 and as you say pretty straightforward to add different python versions.

I have participated in another coding project where we also have done this:
https://github.com/SEE-GEO/pansat/blob/main/.github/workflows/install_and_test.yml
(similar to Metpy).

On the same note, we could also test on operating systems other than Ubuntu, or have we deliberately chosen not to do so?

@freemansw1 freemansw1 added this to the Version 1.5 milestone Oct 24, 2022
@freemansw1
Copy link
Member Author

With us accidentally breaking compatibility in #175, I've tagged this to be done in v1.5, which is when we drop support for <3.7.

On the same note, we could also test on operating systems other than Ubuntu, or have we deliberately chosen not to do so?

No particular reason, other than the Dockerfile was a copy/paste of something else I had done. We can add other linux OSes to our test suite, but given that we don't have any compiled code, it may be redundant.

@mgrover1
Copy link

Happy to help with this effort!

@freemansw1 freemansw1 self-assigned this Nov 18, 2022
@freemansw1 freemansw1 modified the milestones: Version 1.5, Version 1.6 Feb 10, 2023
@freemansw1 freemansw1 modified the milestones: Version 1.6, Version 1.5.x Jun 9, 2023
@w-k-jones
Copy link
Member

Resolved with #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

No branches or pull requests

4 participants