Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scipy interp2d deprecated #268

Closed
freemansw1 opened this issue Apr 20, 2023 · 2 comments · Fixed by #279
Closed

Scipy interp2d deprecated #268

freemansw1 opened this issue Apr 20, 2023 · 2 comments · Fixed by #279
Assignees
@lettlini
Labels
dependency Issues with a dependency or import Low Priority This issue does not need addressing until a future update Refactor Code that doesn't intend to change the functionality, but instead refactor/clean up.
Milestone
Version 1.5

Comments

@freemansw1
Copy link
Member

We need to modify utils.general.add_coordinates and utils.general.add_coordinates_3d to remove scipy.interpolate.interp2d, as that function is now deprecated in scipy 1.10.0. This isn't urgent, but their timeline for removal isn't short, with 1.12.0 being the target for removal.

Note that I think new add_coordinates functions that work using xarray would probably sidestep this issue.
@freemansw1 freemansw1 added Refactor Code that doesn't intend to change the functionality, but instead refactor/clean up. Low Priority This issue does not need addressing until a future update labels Apr 20, 2023
@w-k-jones
Copy link
Member

Should be fairly straightforward to replace all the interp2d calls with interpnd

From my experience multivariate interpolation using xarray is awkward. I'm not sure if it's improved in the last few years

@w-k-jones w-k-jones added the dependency Issues with a dependency or import label Apr 28, 2023
@lettlini lettlini self-assigned this Apr 28, 2023
@w-k-jones w-k-jones added this to the Version 1.5 milestone May 12, 2023
@freemansw1 freemansw1 linked a pull request May 22, 2023 that will close this issue
Refactor: Replace interp2d with interpn #279
Merged
11 tasks
@freemansw1
Copy link
Member Author

This has been resolved with #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lettlini lettlini

Labels
dependency Issues with a dependency or import Low Priority This issue does not need addressing until a future update Refactor Code that doesn't intend to change the functionality, but instead refactor/clean up.
Projects
None yet
Milestone
Version 1.5
Development

Successfully merging a pull request may close this issue.

Refactor: Replace interp2d with interpn lettlini/tobac
3 participants
@freemansw1 @w-k-jones @lettlini