-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter notebooks not generating through CI #286
Comments
Following on from the previous discussion, I think we should manually regenerate the notebooks to avoid this becoming a blocking issue for the release. We can do this quickly when |
@w-k-jones I fully agree with you. |
@lettlini Do we need to disable the CI to avoid the notebooks getting wiped, or will the CI failing have the same effect? Actually, maybe better to do a PR to just remove the CI in the first place; not ideal for the red x to be on our commit for a release. |
@freemansw1 I think we should remove this workflow until we find a good solution on how it works with branch protection rules (see #290). I don't think the notebooks can be changed in any way by the workflow since it cannot push to protected branches. |
Resolved with #308 |
Opening to continue the discussion from #258. In the
RC_V1.5.0
branch, our CI does not work to regenerate our notebooks. Tagging this as an open issue to block v1.5 release until we either resolve by fixing the CI or by manually regenerating the notebooks.The text was updated successfully, but these errors were encountered: