Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plotting.py forces matplotlib backend to agg #95

Closed
freemansw1 opened this issue Mar 24, 2022 · 2 comments
Closed

plotting.py forces matplotlib backend to agg #95

freemansw1 opened this issue Mar 24, 2022 · 2 comments
Assignees
@freemansw1
Labels
bug Code that is failing or producing the wrong result
Milestone
Version 1.3

Comments

@freemansw1
Copy link
Member

In tobac/plotting.py, we force the Matplotlib backend to agg:
https://github.com/climate-processes/tobac/blob/e2af8e0c6f7e78f936c42539660bcb2b20e290c6/tobac/plotting.py#L2

This is not really good practice, especially as it's imported by default when users run import tobac. It's funny, @w-k-jones @galexsky and I were just talking about this. I'll get on a PR to fix this shortly.
@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Mar 24, 2022
@freemansw1 freemansw1 added this to the Version 1.3 milestone Mar 24, 2022
@freemansw1 freemansw1 self-assigned this Mar 24, 2022
@w-k-jones
Copy link
Member

Good spot. Does it cause any problems to plotting when this is removed?

@freemansw1 freemansw1 mentioned this issue Mar 28, 2022
Merged
@freemansw1
Copy link
Member Author

Resolved with #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freemansw1 freemansw1

Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Milestone
Version 1.3
Development

No branches or pull requests
2 participants
@freemansw1 @w-k-jones