[iOS] Add support for colors with alpha #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-ht
changed the title
|
note that colors with alpha in android is currently trick to use as well see #562. The issues with the pipline seem to be unrealted to my changes. Maybe caused by the flutter 2.0 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the iOS version only supports RGB colors such as
#ffee00. Android also supports colors with alphas such as#99ffee00(where99would be the alpha value)The Purpose of this pull request is to add the support to iOS as well.
The Syntax of the color string for iOS can either follow the old format of #rrggbb or the new format #aarrggbb. Thus this change is downwards compatible and should not break any existing code.
#aarrggbb is consistent with the android implementation.