[android] Make build work with instructions in docs #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`build.gradle` currently does not respect the `MAPBOX_DOWNLOADS_TOKEN` project property as subbested by the official docs for Android at https://docs.mapbox.com/android/maps/guides/install/. This approach does not interfere with the `SDK_REGISTRY_TOKEN` environment variable used for CI, but just uses the official approach as a fallback. Also updated docs
|
@shroff if you remove tobrun from the reviewers the ci should be able to run and we can merge it |
|
@felix-ht I'm not sure why that would help, but I did it anyway |
|
@shroff because some parts of the pipeline only run if all the users marked as reviewers did the review. As tobrun didn't do it the build steps did not run. |
|
It seems like the |
|
@philiplindberg can you create a merge request for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.gradlecurrently does not respect theMAPBOX_DOWNLOADS_TOKENproject property as subbested by the official docs for Android at
https://docs.mapbox.com/android/maps/guides/install/.
This approach does not interfere with the
SDK_REGISTRY_TOKENenvironment variable used for CI, but just uses the official approach as
a fallback.
Also updated docs