Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release on pip3? #58

Closed
gendx opened this issue Apr 14, 2020 · 5 comments
Closed

New release on pip3? #58

gendx opened this issue Apr 14, 2020 · 5 comments

Comments

@gendx
Copy link

gendx commented Apr 14, 2020

OpenSK's deploy script depends on the App.get_binary() function from tockloader.

def get_binary (self):
'''
Return the binary array comprising the entire application.
'''
binary = self.tbfh.get_binary() + self.app_binary
# Check that the binary is not longer than it is supposed to be. This
# might happen if the size was changed, but any code using this binary
# has no way to check. If the binary is too long, we truncate the actual
# binary blob (which should just be padding) to the correct length. If
# it is too short it is ok, since the board shouldn't care what is in
# the flash memory the app is not using.
size = self.get_size()
if len(binary) > size:
binary = binary[0:size]
return binary

However, this function is not available in the latest released version of tockloader on pip3. This causes some failures: google/OpenSK#79.

Could you release a new version of tockloader on pip3?

@gendx
Copy link
Author

gendx commented Apr 15, 2020

cc @bradjc

@bradjc
Copy link
Contributor

bradjc commented Apr 15, 2020

I do want to make a new release. Are you running from master? Have you encountered any issues?

@jmichelp
Copy link

Yes, I've been using master for a while (that's why I wasn't picking up that some of the methods were not in the pypi release). No issue so far for OS X and Linux on Nordic boards.

@gendx
Copy link
Author

gendx commented Apr 20, 2020

Any update on this @bradjc?

@gendx
Copy link
Author

gendx commented Apr 28, 2020

@gendx gendx closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants