Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds for arm on windows​ (WOA) #3037

Closed
1 task
intzaaa opened this issue Jul 6, 2023 · 5 comments
Closed
1 task

Builds for arm on windows​ (WOA) #3037

intzaaa opened this issue Jul 6, 2023 · 5 comments
Assignees
Labels
help wanted platform:windows Windows related issues and PRs story Features perceivable by end-users type:feat Non-bug feature improvements

Comments

@intzaaa
Copy link

intzaaa commented Jul 6, 2023

Description

Today, more and more Windows computers are equipped with Arm chips, which are excellent for energy efficiency and are very suitable for text work.

Obsidian has already provided builds for the windows arm64.

Use case

No response

Anything else?

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@intzaaa intzaaa added the story Features perceivable by end-users label Jul 6, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in AFFiNE Project Jul 6, 2023
@himself65 himself65 added type:feat Non-bug feature improvements platform:windows Windows related issues and PRs labels Jul 6, 2023
@Brooooooklyn
Copy link
Member

Block by briansmith/ring#1167

@kanweiwei
Copy link
Contributor

kanweiwei commented Jul 7, 2023

briansmith/ring#1514 (comment)

I have tested the code in this comment and it works on my pd vm. One thing to note is that tokio needs to be downgraded to version 1.28.1 since version 1.29.1 appears to have some errors.

However, during testing, I encountered another problem where the BrowserWindow did not show up after running the command yarn nx dev @affine/electron. The code stopped executing at here.

const helperExposedMeta = await helperProcessManager.rpc?.getMeta();

This issue only occurred on non-macOS platforms, and i don't know much about this code and the async-call-rpc library. Can anyone provide an explanation?

@himself65
Copy link
Contributor

This issue only occurred on non-macOS platforms, and i don't know much about this code and the async-call-rpc library. Can anyone provide an explanation?

async-call-rpc is platform unrelated library, I guarantee that it can be used in all javascript runtime

@EYHN EYHN removed good first issue Good for newcomers help wanted labels Dec 1, 2023
@EYHN EYHN moved this from 🆕 *Untriaged to 🙋 Upvoting in AFFiNE Project Dec 2, 2023
@intzaaa
Copy link
Author

intzaaa commented Feb 3, 2024

Block by briansmith/ring#1167

this issue is closed now 😁

@EYHN EYHN moved this from 🙋 Upvoting to 💡 Open in AFFiNE Project Mar 4, 2024
@forehalo
Copy link
Member

forehalo commented Aug 9, 2024

@Brooooooklyn how's now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted platform:windows Windows related issues and PRs story Features perceivable by end-users type:feat Non-bug feature improvements
Projects
Status: 💡 Open
Development

No branches or pull requests

7 participants