Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edgeless Toolbar Update #5313

Closed
zanwei opened this issue Nov 13, 2023 · 7 comments · Fixed by #5339
Closed

Edgeless Toolbar Update #5313

zanwei opened this issue Nov 13, 2023 · 7 comments · Fixed by #5339
Assignees
Labels
mod:edgeless Module: related to edgeless mode mod:widget Related to positioned menus type:feat Non-bug feature improvements ui-style Related to UI styling

Comments

@zanwei
Copy link
Member

zanwei commented Nov 13, 2023

We would like to have a feature update for Edgeless Toolbar, please refer design
image

Update Details

1. Font Style
We plan to add 6 font families to enrich the diversity of Edgeless. Additionally, the fonts of the current versions of General and Scribble will use their own names, which are Inter(General) and Kalam(Scribble)

It should be noted that when users switch fonts, the Aa in the Toolbar will change according to the style of the font.

image

2. Font Size
We have decided to adopt a method of directly selecting numerical values for adjusting font size. Please note that in the current version, the font size will not change when users input a value greater than 200. However, the value will increase with the extent of dragging. Therefore, please remove this restriction, but limit the maximum font size input by users to not exceed 9999.
image
image

3. Font Weight
In the new version, we will allow users to choose different font-weight. However, please note that we will limit the number of font-weight. Currently, each font will have a maximum of three weights and a minimum of one weight.

  • Please note that if the font has only one font-weight, the dropdown menu will be disabled.
  • Please be aware that the names of the font-weights for each font may vary (some might be Light, Regular, Medium, while others could be Regular, Medium, SemiBold). The specific names should be based on the font files provided by the designer.
image image

Font Resources.zip

@zanwei zanwei assigned zanwei and unassigned zanwei Nov 13, 2023
@hwangdev97
Copy link
Member

cc @Flrande and @doodlewind

@doodlewind doodlewind added mod:edgeless Module: related to edgeless mode type:feat Non-bug feature improvements ui-style Related to UI styling mod:widget Related to positioned menus labels Nov 13, 2023
@oytuntez
Copy link

oytuntez commented Jul 1, 2024

If this text element could be inline formatted just like the Note block, that would be amazing.

@zanwei
Copy link
Member Author

zanwei commented Jul 1, 2024

If this text element could be inline formatted just like the Note block, that would be amazing.

Yes, we're working on it actually :)

@oytuntez
Copy link

oytuntez commented Jul 1, 2024

That's great @zanwei! Is there a PR or branch I can test it out?

It looks like I will need to fork to bring some fixes and features to Blocksuite, so I will already have my local environment set up for your tests etc.

@oytuntez
Copy link

oytuntez commented Jul 1, 2024

@zanwei I am currently editing the Note block to make it look like the EdgelessText element. Should I pursue this path, or will we get this inline formatting feature on EdgelessText soon?

@zanwei
Copy link
Member Author

zanwei commented Jul 1, 2024

@zanwei I am currently editing the Note block to make it look like the EdgelessText element. Should I pursue this path, or will we get this inline formatting feature on EdgelessText soon?

hi @oytuntez we actually finished the development of this feature, however we still need more time to testing. You could try when it out

@oytuntez
Copy link

oytuntez commented Jul 1, 2024

Perfect @zanwei, thank you! Looking forward to testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:edgeless Module: related to edgeless mode mod:widget Related to positioned menus type:feat Non-bug feature improvements ui-style Related to UI styling
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants