vector fixes

Author: gunnarmein-ts

README.md

@@ -8,6 +8,8 @@ The license is unchanged, everything is free under MIT terms.
 
 The npm js installation point has moved: `npm i nerdamer-prime`.
 
+NOTICE: Starting with version 1.2.0, vector and matrix semantics are changing to be more useful for linear algebra. If this causes you problems, please stick with 1.1.26 and let us know so we can see how we could make compatible changes.
+
 Our intentions:
 
 To keep Nerdamer in good repair, and make improvements where we need them and where we can. Mostly bug fixes. If you investigate
@@ -20,7 +22,7 @@ e.g. SymPy in a WASM webworker if you need more. See here for a demo: [SymPy liv
 We have made some improvements - simplification of logs and squareroots, and bug fixes related to those areas and factoring. Unit tests
 are fixed except for a couple of known flaws. There will be further work in this area. We will also work on vectors, which are not 
 useful for our product [together.math](https://www.together.science/) today. Those will be breaking changes 
-(you are welcome to fork an earlier version). 
+(*THESE ARE NOW IN PROGRESS* for versions >= 1.2.0, you are welcome to fork an earlier version). 
 
 If you have a clear bug, file an issue with the code to repro. If you want a new feature - and that includes many things that you will
 think of as "obvious flaws" - file the issue, but we probably won't do it. But someone else can! We will absolutely consider compatible

all.min.js

@@ -11508,12 +11508,12 @@ var nerdamer = (function (imports) {
             while(--n);
             return index;
         },
-        text_: function (x) {
-            let result = text(this);
+        text_: function (x, options) {
+            let result = text(this, options);
             return (this.rowVector?"[":"")+result+(this.rowVector?"]":"");
         },
-        text: function (x) {
-            let result = text(this);
+        text: function (x, options) {
+            let result = text(this, options);
             return (this.rowVector?"[":"")+result+(this.rowVector?"]":"");
         },
         toString: function () {

nerdamer.core.js

@@ -6,7 +6,7 @@
     "description": "javascript light-weight symbolic math library",
     "name": "nerdamer-prime",
     "license": "MIT",
-    "version": "1.1.27",
+    "version": "1.2.0",
     "homepage": "https://github.com/together-science/nerdamer-prime",
     "directory": {
         "lib": "./"

package.json

@@ -325,8 +325,8 @@ describe('Algebra', function () {
         expect(nerdamer('sqrt(2*baseunit_m^2*sin(3*alpha))').toString()).toEqual('baseunit_m*sqrt(2)*sqrt(sin(3*alpha))');
     });
     it('should calculate nth roots correctly', function() {
-        expect(nerdamer('roots((-1)^(1/5))').evaluate().text()).toEqual('[0.5877852522924731*i+0.809016994374947,-0.309016994374947+0.9510565162951536*i,-1,-0.309016994374948-0.9510565162951536*i,-0.5877852522924734*i+0.809016994374947]');
-        expect(nerdamer('roots((2)^(1/3))').evaluate().text()).toEqual('[1.122462048309381,-1.122462048309381]');
+        expect(nerdamer('roots((-1)^(1/5))').evaluate().text()).toEqual('[(181485532/308761629)*i+260449120/321932817,(55918065/58795733)*i-39088169/126491972,-1,(-8795017271979437/9247628423009475)*i-24157817/78176338,(-8677593/14763203)*i+102334155/126491972]');
+        expect(nerdamer('roots((2)^(1/3))').evaluate().text()).toEqual('[131293077/116968834,-131293077/116968834]');
     });
     it('should complete the square', function() {
         expect(nerdamer('sqcomp(a*x^2+b*x-11*c, x)').toString()).toEqual('((1/2)*abs(b)*sqrt(a)^(-1)+sqrt(a)*x)^2+(-1/4)*(abs(b)*sqrt(a)^(-1))^2-11*c');

spec/algebra.spec.js

@@ -1816,7 +1816,7 @@ describe('Nerdamer core', function () {
     });
     it('should remove near duplicates from vectors', function() {
         expect(nerdamer('vectrim([cos(0), 1, 1.000000000000001])').toString()).toEqual('[1]');
-        expect(nerdamer('vectrim([cos(0), 1, 1.000000000000001], 0)').text()).toEqual('[1,1.000000000000001]');
+        expect(nerdamer('vectrim([cos(0), 1, 1.000000000000001], 0)').text()).toEqual('[1,900719925474100/900719925474099]');
     });
     it('should convert degrees to radians', function() {
         expect(nerdamer('radians(45)').toString()).toEqual('(1/4)*pi');

spec/core.spec.js

@@ -63,10 +63,10 @@ describe('Solve', function () {
         expect(nerdamer('solve(x^3-10x^2+31x-30,x)').toString()).toEqual('[3,5,2]');
         expect(nerdamer('solve(8x^3-26x^2+3x+9,x)').toString()).toEqual('[3/4,-1/2,3]');
         expect(nerdamer('solve(x^3-1/2x^2-13/2x-3,x)').toString()).toEqual('[-2,3,-1/2]');
-        expect(nerdamer('solve(x^3+2x^2+3x-4=0,x)').evaluate().text()).toEqual('[0.776045435028538,0.388022717514269+0.6720750612256601*i,-0.388022717514269+0.6720750612256599*i]');
+        expect(nerdamer('solve(x^3+2x^2+3x-4=0,x)').evaluate().text()).toEqual('[70419755/90741794,(9781803879340745/14554630046086988)*i+70419755/181483588,(5721734032321405/8513534220250202)*i-96689750724854153216/249185798564226019925]');
         expect(nerdamer('solve(x*log(x),x)').toString()).toEqual('[1]');
         expect(nerdamer('solve((9x+x^2)^3+10800x+40x^4+4440x^2+720x^3+20(9*x+x^2)^2+8000,x) ').toString()).toEqual('[-5,-4]');
-        expect(nerdamer('solve((x^3-4)/(x^3+7x-11),x)').evaluate().text()).toEqual('[1.587401051968199,0.7937005259840910+1.3747296369986024*i,-0.793700525984099+1.374729636998602*i]');
+        expect(nerdamer('solve((x^3-4)/(x^3+7x-11),x)').evaluate().text()).toEqual('[123554237/77834292,(17162560630828463/12484317038729784)*i+123554237/155668584,(10039007984057947/7302532595409636)*i-17388712991038935924736/21908405527990418074125]');
         expect(nerdamer('solve((93222358/131836323)*(-2*y+549964829/38888386)=10, y)').toString()).toEqual('[1/3625267041734188]');
         expect(nerdamer('solve(sqrt(x)+sqrt(2x+1)=5,x) ').toString()).toEqual('[4]');
         expect(nerdamer('solve(sqrt(x)-1,x) ').toString()).toEqual('[1]');
@@ -95,7 +95,7 @@ describe('Solve', function () {
         // np issue #26
         // expect(nerdamer("solve(h=1/2*(9.81)*m*s^(-2)*t^2, t)").evaluate().text()).toEqual("[0.4515236409857309*s*sqrt(h)*sqrt(m)^(-1),-0.4515236409857309*s*sqrt(h)*sqrt(m)^(-1)]");
         // like:
-        expect(nerdamer("solve(h=1/2*(9.81)*t^2, t)").evaluate().text()).toEqual("[-0.4515236409857309*sqrt(h),0.4515236409857309*sqrt(h)]");
+        expect(nerdamer("solve(h=1/2*(9.81)*t^2, t)").evaluate().text()).toEqual("[(-35364869/78323405)*sqrt(h),(35364869/78323405)*sqrt(h)]");
         expect(nerdamer("h=(981/200)*m*s^(-2)*t^2").solveFor("t").toString()).toEqual('(-10/327)*abs(s)*m^(-1)*sqrt(218)*sqrt(h)*sqrt(m),(10/327)*abs(s)*m^(-1)*sqrt(218)*sqrt(h)*sqrt(m)');
     });
 
@@ -155,8 +155,7 @@ describe('Solve', function () {
         expect(nerdamer('solve(a^2-a-1=0,a)').toString()).toEqual('[(1/2)*sqrt(5)+1/2,(-1/2)*sqrt(5)+1/2]');
         // issue #26
         expect(nerdamer("solve(h=(981/200)*baseunit_m*baseunit_s^(-2)*t^2, t)").text())
-            .toEqual('[-0.0305810397553517*baseunit_m^(-1)*baseunit_s*sqrt(218)*sqrt(baseunit_m)*sqrt(h),'+
-                '0.0305810397553517*baseunit_m^(-1)*baseunit_s*sqrt(218)*sqrt(baseunit_m)*sqrt(h)]');
+            .toEqual('[(-10/327)*baseunit_m^(-1)*baseunit_s*sqrt(218)*sqrt(baseunit_m)*sqrt(h),(10/327)*baseunit_m^(-1)*baseunit_s*sqrt(218)*sqrt(baseunit_m)*sqrt(h)]');
         expect(nerdamer('solve(abs(a-b)=0, a)').toString()).toEqual('[b]');
         expect(nerdamer('solve(abs(a-b)=5, a)').toString()).toEqual('[-5+b,-(-5-b)]');
         // issue #43