Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using without polluting the global namespace #244

Closed
computersarecool opened this issue May 16, 2017 · 1 comment
Closed

Using without polluting the global namespace #244

computersarecool opened this issue May 16, 2017 · 1 comment

Comments

@computersarecool
Copy link

At risk of repeating #112 (which was closed without a solution), in the browser, when including this, all of teh classes are added to the global (window) object.

Would you guys be willing to encapsulate this more so we do not have to use something like browserify to keep this out of the window object?

I think that adding everything to a glMatrix object (which itself if a member of the window object) would be very helpful

@toji
Copy link
Owner

toji commented Jul 21, 2017

#249 converts the library to use ES2015 modules. The pre-compiled scripts in the dist/directory will continue to place all functions in the global namespace, but libraries that want to include a more targeted set of functionality can now use the individual modules directly.

@toji toji closed this as completed Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants