Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth : Enhancing Negative Input for commission rate #119

Open
sifnoc opened this issue Apr 25, 2020 · 0 comments
Open

cmd/geth : Enhancing Negative Input for commission rate #119

sifnoc opened this issue Apr 25, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sifnoc
Copy link
Contributor

sifnoc commented Apr 25, 2020

Currently, Negative Input for setCommission like this.

build/bin/geth  manage-staking setCommissionRate \
    --datadir ./.pls.staking/operator1 \
    --rootchain.url ws://127.0.0.1:8546 \           
    --unlock 0x5e3230019fed7ab462e3ac277e7709b9b2716b4f  \
    --password pwd.pass   \
    --rootchain.sender 0x5e3230019fed7ab462e3ac277e7709b9b2716b4f  \
    -- -0.4

Cause CLI could not recognize with - operator as a minus. treat as starting flag.

And also, the negative commission rate output as following.

rootchain=0xd6662103d7Ffd6D44792d9866AfAD0Beef5d3c32 commissionRate=-0.010

User and Operator may mis reading as a positive rate In a terminal.

I suggest that using prefix "M" with commission rate input.

Expecting result.

build/bin/geth  manage-staking setCommissionRate M0.01 \
    --datadir ./.pls.staking/operator1 \
    --rootchain.url ws://127.0.0.1:8546 \           
    --unlock 0x5e3230019fed7ab462e3ac277e7709b9b2716b4f  \
    --password pwd.pass   \
    --rootchain.sender 0x5e3230019fed7ab462e3ac277e7709b9b2716b4f 

rootchain=0xd6662103d7Ffd6D44792d9866AfAD0Beef5d3c32 commissionRate=M0.010
@sifnoc sifnoc added the enhancement New feature or request label Apr 25, 2020
@sifnoc sifnoc self-assigned this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant