Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific checks to culprits.sh #10

Open
tokee opened this issue Jun 30, 2020 · 0 comments
Open

Add specific checks to culprits.sh #10

tokee opened this issue Jun 30, 2020 · 0 comments
Assignees

Comments

@tokee
Copy link
Owner

tokee commented Jun 30, 2020

Some things like group.ngroups=true are dangerous by themselves in a distributed environment and might call for a warning if they are ever seen.

Other things such as regexp-matches or prefix-queries might be waned against only if the query is slow, where "slow" might be derived by calculating percentiles from the QTimes and setting the limit at 90%.

facet.method=enum might be a problem if there are "a lot" of unique facets. That might be impossible to derive from the log.

@tokee tokee self-assigned this Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant